Chore: Update Jint, Rebus and their dependencies to latest versions + Swashbuckle .net10 bugfix#7518
Open
terry-delph wants to merge 3 commits into
Conversation
Upgraded `System.Text.Encodings.Web` to `10.0.8` and other key dependencies (`Newtonsoft.Json`, `Microsoft.Extensions.Hosting`, etc.) across multiple projects for compatibility, security, and performance improvements. Upgraded `Jint`: - Updated `Jint` to `4.9.2` from beta version - Enhanced `ByteArrayConverter` to handle byte arrays as `ArrayBuffer` in JavaScript - Added new tests for validation Upgrade Rebus dependencies across core projects: - Upgraded Rebus to version 8.9.2 in Elsa.Abstractions.csproj. - Upgraded Rebus.ServiceProvider to version 10.7.2 in Elsa.Core.csproj. - Upgraded Rebus.Microsoft.Extensions.Logging to version 5.2.0 in Elsa.Core.csproj. These upgrades ensure compatibility with the latest features, bug fixes, and improved integration with .NET 8/9/10 targets. Duplicate Swashbuckle packages references: - Removed duplicate Swashbuckle (Swagger) package references from Elsa.Server.Api.csproj for consistent multi-targeting. - Ensured only one version per framework is referenced.
…NET 8/9/10) (Issue: elsa-workflows#7429) - Conditionally upgrade Swashbuckle.AspNetCore.SwaggerGen to 10.2.1 for .NET 10 (keep 6.3.0 for .NET 8/9 for compatibility) - Add conditional compilation for swaggerDoc.Tags initialization - Use HashSet<OpenApiTag> for .NET 10+ - Use List<OpenApiTag> for .NET 8/9 - Add conditional compilation for operation.Tags - Use OpenApiTagReference for .NET 10+ - Use OpenApiTag for .NET 8/9 - Fix RequestBody.Content null reference by explicit initialization - Improve JsonSchema validation to check for null or whitespace - tailwind.css seems to have not been updated in a previous commit, the rebuild has identified some changes Resolves ReflectionTypeLoadException: "Method 'Apply' in type 'HttpEndpointDocumentFilter' does not have an implementation" caused by OpenAPI model breaking changes in .NET 10.
…flows#7502) - Added `[Tags("Secrets")]` to group secrets api endpoints in Swagger UI. - Introduced `RemoveEmptyControllerTagsFilter` to remove unused tags from OpenAPI documents. - Registered the filter in Swagger configuration with .NET 10 compatibility adjustments.
terry-delph
marked this pull request as ready for review
June 5, 2026 11:49
Contributor
|
PR author is not in the allowed authors list. |
Contributor
Author
|
@sfmskywalker |
Open
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Updates
Jint,Rebusand their dependencies to latest versions.Some .net10 fixes for Swashbuckle/OpenAPI issues.
Scope
Select one primary concern:
Description
Problem
Jint
Currently
Jintis on a beta version3.0.0-beta-2037which even if moved to the non beta3.0.0it does not compile as the api changed before beta closed.The latest version is
4.9.2which changes the Parser fromEsprimatoAcornima.Rebus
Rebusis also outdated being on version8.7.1.The latest is version
8.9.2which brings .net10 support with it which Elsa support already so should have been updated already.Swashbuckle .NET 10 Compatibility Fixes
Solution
Upgraded
System.Text.Encodings.Webto10.0.8and other key dependencies (Newtonsoft.Json,Microsoft.Extensions.Hosting, etc.) across multiple projects for compatibility, security, and performance improvements.Upgraded
Jint:Jintto4.9.2from beta versionByteArrayConverterto handle byte arrays asArrayBufferin JavaScriptUpgrade
Rebusdependencies across core projects:Rebusto version8.9.2in Elsa.Abstractions.csproj.Rebus.ServiceProviderto version10.7.2in Elsa.Core.csproj.Rebus.Microsoft.Extensions.Loggingto version5.2.0in Elsa.Core.csproj.Upgraded
System.Text.Encodings.Webto10.0.8and other key dependencies (Newtonsoft.Json,Microsoft.Extensions.Hosting, etc.) across multiple projects for compatibility, security, and performance improvements.These upgrades ensure compatibility with the latest features, bug fixes, and improved integration with .NET 8/9/10 targets.
Duplicate Swashbuckle packages references:
Swashbuckle .NET 10 Compatibility Fixes
Package Updates
HttpEndpointDocumentFilter.cs
swaggerDoc.Tags:IList<OpenApiTag>(.NET 8/9) →ISet<OpenApiTag>(.NET 10)operation.Tags:IList<OpenApiTag>(.NET 8/9) →ISet<OpenApiTagReference>(.NET 10)RequestBody.Contentby explicit dictionary initializationJsonSchemapropertyReflectionTypeLoadException: "Method 'Apply' does not have an implementation"RemoveEmptyControllerTagsFilter.cs
OpenApiTagReference.Reference.Idfor tag identification (.NET 10)OpenApiTag.Namefor tag identification (.NET 8/9)Remove()method forISet<OpenApiTag>(.NET 10)ToList()forIList<OpenApiTag>(.NET 8/9)Verification
Steps:
Expected outcome:
Tests pass and samples run without exceptions.
Eliminates runtime type loading errors on .NET 10
Swagger page does not show Tags with no Operations
Screenshots / Recordings (if applicable)
N/A
Checklist