Fix Switch resume from serialized scheduled state#7444
Draft
sfmskywalker with Copilot wants to merge 2 commits into
Draft
Fix Switch resume from serialized scheduled state#7444sfmskywalker with Copilot wants to merge 2 commits into
sfmskywalker with Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/elsa-workflows/elsa-core/sessions/7fbc9229-29e2-4257-89d8-2890c764c8b1 Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix switch throwing exception on resume from JSON-serialized state
Fix Switch resume from serialized scheduled state
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prevent
Switchfrom throwing when a workflow resumes afterScheduledActivityIdshas round-tripped through JSON serialization.Scope
Select one primary concern:
Description
Problem
Switchstored scheduled child IDs as aHashSet<string>, but serialized workflow state restores that value asList<string>. The completion callback then read the value back asHashSet<string>, causing anInvalidCastExceptionon resume.Solution
ScheduledActivityIdsasICollection<string>so both the originalHashSet<string>and restoredList<string>are accepted.Verification
Steps:
SwitchTests.Switchactivity.Expected outcome:
Switchcompletes normally after resumed child completion whenScheduledActivityIdsis restored asList<string>.Screenshots / Recordings (if applicable)
N/A — no UI changes.
Commit Convention
We recommend using conventional commit prefixes:
fix:– Bug fixes (behavior change)feat:– New featuresrefactor:– Code changes without behavior changedocs:– Documentation updateschore:– Maintenance, tooling, or dependency updatestest:– Test additions or modificationsClear commit messages make reviews easier and history more meaningful.
Checklist