fix: avoid global Parser class collision (#11)#16
Open
anna-d wants to merge 1 commit into
Open
Conversation
- Rename interface Parser → WFS_Parser - Rename concrete parsers: - Pdf → WFS_Parser_Pdf - Docx → WFS_Parser_Docx - Odt → WFS_Parser_Odt This resolves a fatal error when WP File Search is activated alongside plugins that also declare a global Parser class (e.g. Ninja Forms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a fatal error that occurs when WP File Search is activated
alongside plugins that also declare a global
Parserclass (e.g., Ninja Forms).Error example:
Fatal error: Cannot declare class Parser, because the name is already in useChanges
Parser→WFS_ParserPdf→WFS_Parser_PdfDocx→WFS_Parser_DocxOdt→WFS_Parser_OdtWhy
Ensures WP File Search does not collide with other plugins that define a
Parserclass in the global namespace, allowing coexistence without fatal errors.Testing