Skip to content

fix: use ipfsHash for unpublishedDeployments pagination #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmigone merged 2 commits into from
Jun 12, 2026
Merged

fix: use ipfsHash for unpublishedDeployments pagination #1207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
796a389
fix: use ipfsHash for unpublishedDeployments pagination
tmigone Jun 12, 2026
e616536
chore: rename variable
tmigone Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/network/subgraph_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ impl Client {
}
unpublishedDeployments: subgraphDeployments(
block: $block
orderBy: id, orderDirection: asc
orderBy: ipfsHash, orderDirection: asc
first: $first
where: {
id_gt: $lastUnpublished
ipfsHash_gt: $lastUnpublished
activeSubgraphCount: 0
}
) {
Expand Down Expand Up @@ -253,8 +253,8 @@ impl Client {

debug_assert!(self.page_size > 0);
let mut query_block: Option<Block> = None;
let mut last_id: Option<String> = None;
let mut last_unpublished_id: Option<String> = None;
let mut last_subgraph_id: Option<String> = None;
let mut last_unpublished_ipfs_hash: Option<String> = None;
let mut subgraphs_done = false;
let mut unpublished_done = false;
let mut results: Vec<Subgraph> = Default::default();
Expand All @@ -277,8 +277,8 @@ impl Client {
"variables": {
"block": block_height,
"first": self.page_size,
"last": last_id.clone().unwrap_or_default(),
"lastUnpublished": last_unpublished_id.clone().unwrap_or_default(),
"last": last_subgraph_id.clone().unwrap_or_default(),
"lastUnpublished": last_unpublished_ipfs_hash.clone().unwrap_or_default(),
},
});
let response = self
Expand Down Expand Up @@ -327,15 +327,15 @@ impl Client {
}

if !subgraphs_done {
last_id = data.results.last().map(|entry| entry.id.to_string());
last_subgraph_id = data.results.last().map(|entry| entry.id.to_string());
if data.results.len() < self.page_size {
subgraphs_done = true;
}
results.append(&mut data.results);
}

if !unpublished_done {
last_unpublished_id = data
last_unpublished_ipfs_hash = data
.unpublished_deployments
.last()
.map(|entry| entry.id.to_string());
Expand Down
Loading