Replace mvn help:effective-pom with git-pkgs/pom binary#1581
Open
andrew wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the JVM-based
mvn help:effective-pomshell-out forpom(https://github.com/git-pkgs/pom), a pure-Go effective-POM resolver.generate_effective_pomnow pipes the POM bytes topom -f - -xml -repo <registry_url>and reads the merged XML back on stdout. The contract is unchanged (returns an XML string, falls back to the raw input on any error) soBibliothecary::Parsers::Mavenandmapping_from_pom_xmlare untouched. Still gated onENABLE_MAVEN_EFFECTIVE_POM.The Redis-backed
wait_for_maven_capacity/release_maven_capacitythrottle is gone since the new binary is a few ms of CPU and a few hundred KB resident, versus ~1-2s and ~128MB per JVM.mavenandcoreutilsare dropped from the Docker image and thepombinary (v0.1.2) is fetched from the GitHub release.The emitted XML carries
groupId,artifactId,version,packaging,name,description,url,licenses,scm,properties,distributionManagement/relocation, and interpolateddependencies. It does not include<repositories>or<distributionManagement>repository URLs, sometadata.repositorieswill be empty for POMs that only declare those in a parent. The five existingENABLE_MAVEN_EFFECTIVE_POM-gated tests are still skipped in CI; their expectations aroundrepositoriesandpropertieswill need a pass when someone runs them locally.Three new tests cover the happy path through the binary (using the parent-less zio fixture so it's hermetic), the failure fallback, and the disabled-env no-op. CI installs
pomfrom the release tarball so the first of those runs on every push.