Fix refresh of VIEWS view after applying configuration#365
Merged
Conversation
Add missing await call when calling onCustomizationClick() when handling the customization click button. Waiting ensures that the method updateAvailableViews() method to refresh the view is called after the customization is applied. Fixes eclipse-cdt-cloud#364 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
fix-config-refresh
branch
from
c970afd to
6d3c7bc
Compare
TheMatthew
approved these changes
Nov 7, 2025
TheMatthew
left a comment
TheMatthew
left a comment
There was a problem hiding this comment.
I approve, but can you think of a unit test in the future? Really curious.
MatthewKhouzam
approved these changes
Nov 7, 2025
Contributor
Author
Yes, Unit tests would be good. Right now the vscode-trace-extension has only limited playwright tests and there are no tests testing the webviews itself. There needs to be some initial webview tests first implemented to add specific test. I defer adding tests that tests this PR when those tests are available. Beyond vscode-trace-extension specific tests, there should be specific tests testing the traceviewer-libs components. A few of them are still in the theia-trace-extension repository. Testing the libs needs some overall work on the testing strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fix refresh of VIEWS view after applying configuration by adding missing await call when calling onCustomizationClick() when handling the customization click button. Waiting ensures that the method updateAvailableViews() method to refresh the view is called after the customization is applied.
Fixes #364
How to test
Create a valid InAndOut customization and make sure that the VIEWs view is showing the customized views.
Follow-ups
Review checklist