Skip to content

Fix IllegalArgumentException by calling PdfContentByte.beginMarkedCon…#2435

Merged
merks merged 1 commit into
eclipse-birt:masterfrom
giangianoulas:2434.IllegalArgumentExxception
Jun 16, 2026
Merged

Fix IllegalArgumentException by calling PdfContentByte.beginMarkedCon…#2435
merks merged 1 commit into
eclipse-birt:masterfrom
giangianoulas:2434.IllegalArgumentExxception

Conversation

@giangianoulas

Copy link
Copy Markdown
Contributor

Fix IllegalArgumentException by calling PdfContentByte.beginMarkedContentSequence only if required (#2434), related to #2430

@giangianoulas giangianoulas force-pushed the 2434.IllegalArgumentExxception branch from 01b648c to 930d7ae Compare June 16, 2026 07:03
@merks merks requested a review from hvbtup June 16, 2026 09:27

@hvbtup hvbtup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I actually meant to rename the variable only, but I don't mind.

Is this PR independent from #2435 or does it depend on it?

If independent: OK

@merks

merks commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I tried to rebase, but it didn't want to do that. The changes are in the same file as the previous merged changed. I restarted the GHA to se that it passed.

@giangianoulas

Copy link
Copy Markdown
Contributor Author

@hvbtup you probably meant #2432 or #2429. It is a standalone change.
I didn't like the method name that much too

@merks merks merged commit df906ce into eclipse-birt:master Jun 16, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants