response body from image+url request for better error reporting #2334 by mithrandirii · Pull Request #2350 · eclipse-birt/birt

mithrandirii · 2025-12-15T14:51:18Z

Added response body to failed responses in ResourceLocatorWrapper #2334

hvbtup

I don't know if this routine can also be called for other types of URLs, eg file URLs.
I think the error body "No HTTP-Protocol" is useless and even misleading in this case.
extractErrorBody should only be called for HTTP protocols.

mithrandirii · 2025-12-16T15:37:36Z

@hvbtup valid point, i changed the pull-request

merks · 2025-12-17T09:06:46Z

@mithrandirii

This seems fine. Could you please share what the resulting error looks like?

wimjongman · 2026-02-12T12:04:48Z

@mithrandirii

This seems fine. Could you please share what the resulting error looks like?

@mithrandirii Can you please respond?

wimjongman · 2026-03-11T12:13:17Z

Moved to 4.24

wimjongman · 2026-06-08T12:28:10Z

Closed. Author @mithrandirii does not respond.

mithrandirii · 2026-06-08T17:48:44Z

@wimjongman sorry to not respond. i was off for a long time. the email from github reminded me.
we still need this change. is there any chance to get this into 4.24? in the next message i will respond to the answer from @merks

mithrandirii · 2026-06-08T17:50:07Z

the log message without the change is:

Jun 08, 2026 7:44:51 PM org.eclipse.birt.report.engine.util.ResourceLocatorWrapper findResource
WARNING: http://localhost:3080/logo/test/logo.svg is not accessible.

and with the change:

Jun 08, 2026 7:39:10 PM org.eclipse.birt.report.engine.util.ResourceLocatorWrapper findResource
WARNING: http://localhost:3080/logo/test/logo.svg is not accessible.
java.io.IOException: {"success":false,"message":"logo not found"}
	at org.eclipse.birt.report.engine.util.ResourceLocatorWrapper.findResource(ResourceLocatorWrapper.java:97)
	at org.eclipse.birt.report.engine.emitter.ImageReader.readImage(ImageReader.java:260)
	at org.eclipse.birt.report.engine.emitter.ImageReader.readImage(ImageReader.java:250)
	at org.eclipse.birt.report.engine.emitter.ImageReader.read(ImageReader.java:129)
	at org.eclipse.birt.report.engine.nLayout.area.impl.ImageAreaLayout.initialize(ImageAreaLayout.java:93)
	at org.eclipse.birt.report.engine.nLayout.area.impl.ImageAreaLayout.layout(ImageAreaLayout.java:84)
	at org.eclipse.birt.report.engine.nLayout.LayoutEngine.startContent(LayoutEngine.java:426)
	at org.eclipse.birt.report.engine.emitter.ContentEmitterAdapter.startImage(ContentEmitterAdapter.java:181)
	at org.eclipse.birt.report.engine.emitter.ContentEmitterUtil.startContent(ContentEmitterUtil.java:86)
	at org.eclipse.birt.report.engine.layout.html.buffer.HTMLPageBuffer.startContent(HTMLPageBuffer.java:102)
	at org.eclipse.birt.report.engine.layout.html.buffer.TableBreakBuffer.startContent(TableBreakBuffer.java:226)
	at org.eclipse.birt.report.engine.layout.html.HTMLLeafItemLM.start(HTMLLeafItemLM.java:65)
	at org.eclipse.birt.report.engine.layout.html.HTMLAbstractLM.layout(HTMLAbstractLM.java:132)
	at org.eclipse.birt.report.engine.layout.html.HTMLBlockStackingLM.layoutNodes(HTMLBlockStackingLM.java:66)
	at org.eclipse.birt.report.engine.layout.html.HTMLPageLM.layout(HTMLPageLM.java:92)
	at org.eclipse.birt.report.engine.layout.html.HTMLReportLayoutEngine.layout(HTMLReportLayoutEngine.java:97)
	at org.eclipse.birt.report.engine.presentation.ReportDocumentBuilder.build(ReportDocumentBuilder.java:226)
	at org.eclipse.birt.report.engine.api.impl.RunTask.doRun(RunTask.java:224)
	at org.eclipse.birt.report.engine.api.impl.RunTask.run(RunTask.java:108)
	at org.eclipse.birt.report.designer.ui.preview.editors.AbstractViewer.createReportDocument(AbstractViewer.java:90)
	at org.eclipse.birt.report.designer.ui.viewer.StaticHTMLViewer.renderReport(StaticHTMLViewer.java:666)
	at org.eclipse.birt.report.designer.ui.viewer.StaticHTMLViewer$16.work(StaticHTMLViewer.java:761)
	at org.eclipse.birt.report.designer.ui.viewer.job.AbstractJob.run(AbstractJob.java:48)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

the string "{"success":false,"message":"logo not found"}" is the html body of a example http image resource

mithrandirii · 2026-06-08T17:54:04Z

to get this working correctly i had to add two futher lines. i added it to my fork, but i don't know how to update the pr. maybe it only works for open pull-requests

merks · 2026-06-08T18:21:34Z

Amend the commit and force push it. There is one day left to close off the 4.24 release

merks · 2026-06-08T18:22:27Z

And be sure to rebase in master or the build will definitely fail.

mithrandirii · 2026-06-08T18:54:44Z

big thx for reopening the pr!

if i look to files changed tab all commits are included.

one check was cancelled:

build
Canceling since a higher priority waiting request for refs/pull/2350/merge exists

CI
Canceling since a higher priority waiting request for refs/pull/2350/merge exists

but i don't understand why! soory, what do i need to do?

wimjongman · 2026-06-08T18:59:05Z

@copilot review security implications.

merks · 2026-06-08T19:02:26Z

This commit chain is kind of a mess now. I don’t want to merge it in this form. If you’re not sure how to squash a single commit rebased on master, then maybe check out master, pull, and create a new branch that you push to your fork for a new pull request. I can have a look tomorrow, but it’s too late in the day for me.

mithrandirii · 2026-06-08T19:35:18Z

ok, i think i have it now. thx again for the support!

merks

Looks okay, though for me testing with a broken link, the error stream does not contain anything useful:

More of concern is that if the connection isn't a URL connection, for which disconnect is called, the stream itself is not closed. I imagine disconnect closes it, but that's not called in all cases. I think that should be better guarded.

Better safe than sorry:

				try {
					connection = url.openConnection();
					try (InputStream in = connection.getInputStream()) {
						inBytes = getByteArrayFromInputStream(in);
						cache.put(url, inBytes);
					}
				} catch (IOException e) {

Copilot

Pull request overview

Enhances BIRT report engine resource loading diagnostics by attaching HTTP response bodies (when available) to warning logs for failed URL-based resource retrievals, improving troubleshooting for dynamic image URL failures (Issue #2334).

Changes:

Switches URL resource retrieval from url.openStream() to an explicit URLConnection to enable access to HTTP error streams.
Logs failures via a LogRecord to preserve i18n message formatting while optionally attaching a throwable containing response-body details.
Adds helper logic to extract and truncate HTTP error response bodies.

mithrandirii · 2026-06-09T07:28:26Z

i implemented changerequests from @merks and copilot.

the resulting message looks like this now:

Jun 09, 2026 9:23:55 AM org.eclipse.birt.report.engine.util.ResourceLocatorWrapper findResource
WARNING: http://localhost:3080/logo/test/logo.svg is not accessible.
java.io.IOException: {"success":false,"message":"logo not found"}
	at org.eclipse.birt.report.engine.util.ResourceLocatorWrapper.findResource(ResourceLocatorWrapper.java:97)
	at org.eclipse.birt.report.engine.emitter.ImageReader.readImage(ImageReader.java:260)
	at org.eclipse.birt.report.engine.emitter.ImageReader.readImage(ImageReader.java:250)
	at org.eclipse.birt.report.engine.emitter.ImageReader.read(ImageReader.java:129)
	at org.eclipse.birt.report.engine.nLayout.area.impl.ImageAreaLayout.initialize(ImageAreaLayout.java:93)
	at org.eclipse.birt.report.engine.nLayout.area.impl.ImageAreaLayout.layout(ImageAreaLayout.java:84)
	at org.eclipse.birt.report.engine.nLayout.LayoutEngine.startContent(LayoutEngine.java:426)
	at org.eclipse.birt.report.engine.emitter.ContentEmitterAdapter.startImage(ContentEmitterAdapter.java:181)
	at org.eclipse.birt.report.engine.emitter.ContentEmitterUtil.startContent(ContentEmitterUtil.java:86)
	at org.eclipse.birt.report.engine.layout.html.buffer.HTMLPageBuffer.startContent(HTMLPageBuffer.java:102)
	at org.eclipse.birt.report.engine.layout.html.buffer.TableBreakBuffer.startContent(TableBreakBuffer.java:226)
	at org.eclipse.birt.report.engine.layout.html.HTMLLeafItemLM.start(HTMLLeafItemLM.java:65)
	at org.eclipse.birt.report.engine.layout.html.HTMLAbstractLM.layout(HTMLAbstractLM.java:132)
	at org.eclipse.birt.report.engine.layout.html.HTMLBlockStackingLM.layoutNodes(HTMLBlockStackingLM.java:66)
	at org.eclipse.birt.report.engine.layout.html.HTMLPageLM.layout(HTMLPageLM.java:92)
	at org.eclipse.birt.report.engine.layout.html.HTMLReportLayoutEngine.layout(HTMLReportLayoutEngine.java:97)
	at org.eclipse.birt.report.engine.presentation.ReportDocumentBuilder.build(ReportDocumentBuilder.java:226)
	at org.eclipse.birt.report.engine.api.impl.RunTask.doRun(RunTask.java:224)
	at org.eclipse.birt.report.engine.api.impl.RunTask.run(RunTask.java:108)
	at org.eclipse.birt.report.designer.ui.preview.editors.AbstractViewer.createReportDocument(AbstractViewer.java:90)
	at org.eclipse.birt.report.designer.ui.viewer.StaticHTMLViewer.renderReport(StaticHTMLViewer.java:666)
	at org.eclipse.birt.report.designer.ui.viewer.StaticHTMLViewer$16.work(StaticHTMLViewer.java:761)
	at org.eclipse.birt.report.designer.ui.viewer.job.AbstractJob.run(AbstractJob.java:48)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.io.IOException: Server returned HTTP response code: 500 for URL: http://localhost:3080/logo/bimme/logo.svg
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:2028)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1629)
	at org.eclipse.birt.report.engine.util.ResourceLocatorWrapper.findResource(ResourceLocatorWrapper.java:84)
	... 23 more

wimjongman · 2026-06-09T07:39:29Z

@mithrandirii please resolve the conversations that you have implemented.

merks · 2026-06-09T08:06:37Z

And please amend the commit and force push it, because we again have 3 commits. We don't want the intermediate stages commit to the repository and we don't want to use squash and merge because it mess up the committer email to be some github bot thing. So this should be a single commit...

mithrandirii · 2026-06-09T08:18:38Z

ok, @wimjongman: resolved the conversations and @merks force-pushed to one commit

merks

Looks better. Thanks!

merks · 2026-06-09T08:39:14Z

@wimjongman

I assume we are comfortable merging this before a final milestone build today?

wimjongman · 2026-06-09T08:41:15Z

@wimjongman

I assume we are comfortable merging this before a final milestone build today?

Yes, please go ahead.

mithrandirii · 2026-06-09T08:47:06Z

big thx to all for the support and the merge before the release

merks · 2026-06-09T08:54:00Z

A nightly build has been twigged and when that''s done I will trigger a milestone build which is the release candidate for tomorrow.

wimjongman · 2026-06-09T09:14:49Z

Thanks Ed @merks, and thank you for the patch @mithrandirii.

mithrandirii changed the title ~~WIP: response body from image+url request for better error reporting #2334~~ response body from image+url request for better error reporting #2334 Dec 15, 2025

hvbtup reviewed Dec 16, 2025

View reviewed changes

hvbtup approved these changes Dec 17, 2025

View reviewed changes

wimjongman added this to the 4.23 milestone Feb 12, 2026

wimjongman modified the milestones: 4.23, 4.24 Mar 11, 2026

wimjongman closed this Jun 8, 2026

merks reopened this Jun 8, 2026

mithrandirii force-pushed the master branch from 554e50f to 9926e13 Compare June 8, 2026 19:27

merks requested changes Jun 9, 2026

View reviewed changes

wimjongman requested a review from Copilot June 9, 2026 07:04

Copilot started reviewing on behalf of wimjongman June 9, 2026 07:05 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Include HTTP error response body in ResourceLocatorWrapper

8a8f0a6

mithrandirii force-pushed the master branch from bb39fdf to 8a8f0a6 Compare June 9, 2026 08:14

merks approved these changes Jun 9, 2026

View reviewed changes

wimjongman linked an issue Jun 9, 2026 that may be closed by this pull request

response body from image+url request for better error reporting #2334

Closed

merks merged commit 78c41fd into eclipse-birt:master Jun 9, 2026
3 checks passed

Uh oh!

Conversation

mithrandirii commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hvbtup left a comment

Choose a reason for hiding this comment

Uh oh!

mithrandirii commented Dec 16, 2025

Uh oh!

merks commented Dec 17, 2025

Uh oh!

wimjongman commented Feb 12, 2026

Uh oh!

wimjongman commented Mar 11, 2026

Uh oh!

wimjongman commented Jun 8, 2026

Uh oh!

mithrandirii commented Jun 8, 2026

Uh oh!

mithrandirii commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mithrandirii commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merks commented Jun 8, 2026

Uh oh!

merks commented Jun 8, 2026

Uh oh!

mithrandirii commented Jun 8, 2026

Uh oh!

wimjongman commented Jun 8, 2026

Uh oh!

merks commented Jun 8, 2026

Uh oh!

mithrandirii commented Jun 8, 2026

Uh oh!

merks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mithrandirii commented Jun 9, 2026

Uh oh!

wimjongman commented Jun 9, 2026

Uh oh!

merks commented Jun 9, 2026

Uh oh!

mithrandirii commented Jun 9, 2026

Uh oh!

merks left a comment

Choose a reason for hiding this comment

Uh oh!

merks commented Jun 9, 2026

Uh oh!

wimjongman commented Jun 9, 2026

Uh oh!

Uh oh!

mithrandirii commented Jun 9, 2026

Uh oh!

merks commented Jun 9, 2026

Uh oh!

wimjongman commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mithrandirii commented Dec 15, 2025 •

edited

Loading

mithrandirii commented Jun 8, 2026 •

edited

Loading

mithrandirii commented Jun 8, 2026 •

edited

Loading

merks left a comment •

edited

Loading