release: enforce build-test rehearsal pairing; drop dead version/docs targets - #338
Open
warun7 wants to merge 1 commit into
Open
release: enforce build-test rehearsal pairing; drop dead version/docs targets#338warun7 wants to merge 1 commit into
warun7 wants to merge 1 commit into
Conversation
… targets Dispatching the Release workflow with target_branch=build-test used to accept any bump, so a rehearsal with the default bump=patch burned a version number and opened a release PR into develop. The release-pr job now validates the documented pairing first -- build-test requires bump=none -- before anything mutates. Also drops two dead targets: sync-version.mjs carried required:false entries under skills/cad/scripts/packages/implicitjs/ -- a mirror that exists nowhere in the tree (the cad skill ships only cadgen and cadjs) -- and test-docs.sh gated a `git lfs pull` of docs/public/hero on finding hero files in LFS, which .gitattributes deliberately excludes.
warun7
force-pushed
the
ci/bundle-check-and-release-validation
branch
from
August 26, 2026 09:13
ea2275c to
bc3a7c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small release-tooling fixes.
Release workflow accepts invalid build-test dispatches
AGENTS.md/CONTRIBUTING.mdsaytarget_branch=build-testis strictly a CI/CD rehearsal that must be paired withbump=none, but nothing enforced it: dispatching with the defaultbump=patchburned a version number and opened a release PR intodevelop. Therelease-prjob now validates the pairing in its first step - before anything mutates - and fails with an actionable::error::.Dead version-sync targets
sync-version.mjscarriedrequired:falseentries underskills/cad/scripts/packages/implicitjs/- a mirror that exists nowhere (the cad skill ships onlycadgenandcadjs). Removed. Theimplicit-cadpair stays: that path resolves through the vendored-runtime layout.Dead hero-GLB LFS branch in test-docs.sh
.gitattributesmarksdocs/public/hero/**deliberately non-LFS, so the script'sgit lfs ls-files | grep docs/public/herogate never matched and the pull never ran. Removed with a comment so it stays gone.Verification
sync-version.mjs --check: metadata synced from VERSIONscripts/bundle/bundle.sh --check: all outputs up to datescripts/test/test-global.sh: 86 tests OKnpm run checktail (local eslint gap only; CI covers)