Handle unavailable TypeScript checks by keppo-bot[bot] · Pull Request #3845 · dyad-sh/dyad

keppo-bot · 2026-07-09T00:47:55Z

Summary

fix: handle unavailable TypeScript checks
Primary files: .claude/skills/pr-push/SKILL.md, .claude/skills/pr-push/scripts/pr_push.sh, .github/workflows/release.yml, e2e-tests/cloud_sandbox.spec.ts, e2e-tests/database_url_guide.spec.ts, e2e-tests/dynamic_models.spec.ts

wwwillchen · 2026-07-09T00:48:03Z

dyad-assistant · 2026-07-09T00:53:51Z

🔍 Dyadbot Code Review Summary

Verdict: ✅ YES - Ready to merge
Recommendation: ready

This PR adds structured error handling for TypeScript unavailability across the full stack: worker thread, main process, IPC handlers, agent tool, and renderer UI. The implementation is well-architected with clean separation between worker-side TscWorkerPreconditionError, main-process TypeCheckPreconditionError, and context-aware guidance messages (agent vs user-facing). Error classification uses DyadError with DyadErrorKind.Precondition correctly, ensuring these expected failures are filtered from PostHog telemetry. Tests are comprehensive, covering the tsc processor, the agent tool's three precondition paths, and the new dyad-command markdown rendering.

Issues Summary

Severity	File	Issue
🟡 MEDIUM	`src/ipc/types/proposals.ts:54`	SuggestedActionSchema Zod union missing AddTypeScriptAction
🟡 MEDIUM	`src/components/preview_panel/Problems.tsx:267`	Error state reuses empty-state heading i18n key

🟢 Low Priority Notes (4 items)

Dual error class hierarchy is justified - TscWorkerPreconditionError (worker thread) and TypeCheckPreconditionError (main process) look duplicative but are necessary since worker threads can't share class instances across the serialization boundary. The errorKind field on WorkerOutput bridges the gap cleanly. (workers/tsc/tsc_worker.ts, src/ipc/processors/tsc.ts)
String-matching fallback is a good safety net - getStringMatchedTypeCheckPreconditionKind provides backward compatibility for errors that don't carry the structured errorKind field (e.g., older code paths or unexpected error wrapping). (src/ipc/processors/tsc.ts)
Hardcoded English prompt in AddTypeScriptButton is correct - The prompt goes to the AI agent, not the user-facing UI, so it should remain in English regardless of locale. (src/components/chat/ChatInput.tsx)
appPath hoisting in problems_handlers is safe - If the error occurs before getDyadAppPath runs (e.g., DB query failure), appPath remains "". But DB/NotFound errors won't match the TypeScript precondition patterns, so the preconditionKind check will be undefined and the new code path won't execute. (src/ipc/handlers/problems_handlers.ts)

Generated by Dyadbot persona-based code review

wwwillchen · 2026-07-09T01:06:57Z

@BugBot run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f028ddfcc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dyad-assistant

Claude review: 2 inline finding(s).

dyad-assistant · 2026-07-09T01:15:01Z

🔍 Dyadbot Code Review Summary

Verdict: ✅ YES - Ready to merge
Recommendation: ready

This PR cleanly handles the case where TypeScript type checking is unavailable. The structured error propagation from worker -> main process -> UI is well-layered, IPC boundary concerns are correctly handled (the TypeCheckPreconditionError class identity is only checked on the main process side; the renderer receives pre-formatted guidance via error.message), and cache invalidation on the error path follows established patterns. Test coverage for the three precondition scenarios is solid.

Issues Summary

Severity	File	Issue
🟡 MEDIUM	`src/ipc/handlers/problems_handlers.ts:43`	Hoisted `appPath=""` could pass empty string to guidance if future code adds a precondition throw before assignment
🟡 MEDIUM	`src/ipc/processors/tsc.ts:126`	`toProblemReportError` silently drops `errorKind` for existing DyadError instances

🟢 Low Priority Notes (2 items)

Positive: Cache invalidation on error path - run_type_checks.ts correctly sends { problems: [] } to clear stale UI data when type checking is unavailable, and the new rule in rules/local-agent-tools.md documents this pattern for future tool authors. (src/pro/main/ipc/handlers/local_agent/tools/run_type_checks.ts)
Positive: AddTypeScriptButton prompt quality - The one-click button sends a prompt specifying allowJs: true and strict: false, which is the right approach for adding TS to an existing JS project without breaking builds. (src/components/chat/ChatInput.tsx)

Generated by Dyadbot persona-based code review

wwwillchen · 2026-07-09T02:40:03Z

@BugBot run

wwwillchen · 2026-07-09T02:40:27Z

🤖 Claude Code Review Summary

PR Confidence: 5/5

All trusted review threads were addressed with code changes, resolved explicitly, and the targeted tests plus fmt/lint/type-check passed.

Unresolved Threads

No unresolved threads

Resolved Threads

Issue	Rationale	Link
Type-check guidance referenced unavailable `add_dependency` tool	Added a turn-scoped `canInstallDependencies` capability derived from `shouldIncludeTool(addDependencyTool, ...)`, and used it to show install-tool guidance only when the tool is actually available.	View
Problem handler could pass empty `appPath` to precondition guidance after future edits	Added a defensive `if (!appPath) { throw error; }` guard before path-based guidance generation.	View
`toProblemReportError` preserved `DyadError` without explaining ignored `errorKind`	Added a brief comment clarifying that already-classified `DyadError` instances intentionally keep their original kind.	View

Product Principle Suggestions

No suggestions

🤖 Generated by Claude Code

- Gate type-check dependency guidance on add_dependency availability - Guard problem precondition guidance before appPath is assigned - Document preserved DyadError classification

wwwillchen · 2026-07-09T02:47:31Z

@BugBot run

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e61688041f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-09T02:52:01Z

+    streamMessage({
+      prompt:
+        "Add TypeScript to this project: install `typescript` as a dev dependency and create a lenient tsconfig (`allowJs: true`, `strict: false`) so existing JavaScript keeps working.",
+      chatId,
+    });


Route Add TypeScript clicks to a writable mode

When this command is rendered after run_type_checks runs in Ask/read-only or Plan mode, clicking it sends a normal message without requestedChatMode, so useStreamChat reuses the current chat's read-only/plan mode and handleLocalAgentStream still filters out state-changing tools like add_dependency/file writes. In those modes the one-click “Add TypeScript” remediation cannot actually install TypeScript or create tsconfig, even though the guidance says the user can accept it with one click; force a writable mode or avoid showing this action when the current chat cannot modify the app.

Useful? React with 👍 / 👎.

wwwillchen · 2026-07-09T02:53:01Z

@BugBot run

dyad-assistant · 2026-07-09T03:01:20Z

🔍 Dyadbot Code Review Summary

Verdict: ✅ YES - Ready to merge
Recommendation: ready

This PR gracefully handles cases where TypeScript type checking is unavailable in user projects (no TypeScript installed, missing tsconfig, incomplete node_modules). The implementation is well-layered across the worker, main process, and renderer, with proper error classification, context-aware guidance messages, and comprehensive test coverage.

What was reviewed:

Worker-level error classification (workers/tsc/tsc_worker.ts): TscWorkerPreconditionError with structured errorKind correctly propagated through the serializable WorkerOutput.errorKind field across the worker boundary.
Main-process error handling (src/ipc/processors/tsc.ts): TypeCheckPreconditionError extending DyadError(Precondition) with the typeCheckKind discriminant. getTypeCheckPreconditionKind correctly prioritizes instanceof over string-matching fallback. toProblemReportError properly passes through the worker's structured errorKind.
Guidance generation (getTypeCheckPreconditionGuidance): Context-aware messages based on whether TypeScript is declared in package.json, with separate agent-directed and user-facing variants via includeAgentInstructions.
Agent tool handler (run_type_checks.ts): Catches DyadError(Precondition) errors, clears the renderer problems cache (following the rule about IPC cache coherency on error paths), shows a <dyad-output type="warning"> in the UI, and returns actionable guidance to the agent.
IPC handler (problems_handlers.ts): Re-wraps precondition errors with user-facing guidance text as a DyadError(Precondition), correctly serialized across IPC via serializeIpcError/deserializeIpcError.
Chat stream handler (chat_stream_handlers.ts): Downgrades known precondition errors to logger.info, reducing noise in error logs.
UI (Problems.tsx, ChatInput.tsx): Error state in Problems panel with AlertTriangle icon, recheck button, and user-friendly message. New AddTypeScriptButton action for the <dyad-command type="add-typescript"> flow.
Tests: New run_type_checks.spec.ts with 4 scenarios (TS declared but missing, plain JS project, missing tsconfig, unexpected error rethrow). Updated tsc.test.ts and DyadMarkdownParser.test.tsx with appropriate mocks.
IPC security boundary: No new filesystem or process access exposed. Error guidance reads package.json from the already-trusted appPath. All inputs validated through existing typed handler contracts.
i18n: addTypeScript key added to all 4 locales (en, es, pt-BR, zh-CN).

✅ No issues found by persona-based review.

🟢 Low Priority Notes (3 items)

tsconfig-not-found guidance ignores includeAgentInstructions - The getTypeCheckPreconditionGuidance function returns identical text for tsconfig-not-found regardless of whether it's agent-directed or user-facing. The other error paths provide richer agent instructions (explicit <dyad-command> tags, "Do not call again" directives). This inconsistency is minor since "You can create a suitable tsconfig for this project and retry" is adequate for both audiences. (src/ipc/processors/tsc.ts)
packageJsonDeclaresTypeScript silently swallows all read/parse errors - If package.json is unreadable (permissions, corrupt JSON), the function returns false, leading to "project does not use TypeScript" guidance. This is a reasonable default but could mask filesystem issues. Consider logging at logger.warn() level for non-ENOENT errors. (src/ipc/processors/tsc.ts)
Hardcoded English guidance strings - The user-facing guidance messages from getTypeCheckPreconditionGuidance (shown in the Problems panel via IPC error) are hardcoded in English while the UI button label (addTypeScript) is i18n-translated. This is consistent with how other IPC error messages work in the codebase but worth noting for future i18n efforts. (src/ipc/processors/tsc.ts)

Generated by Dyadbot persona-based code review

github-actions · 2026-07-09T05:09:06Z

🎭 Playwright Test Results

❌ Some tests failed

OS	Passed	Failed	Flaky	Skipped
🍎 macOS	386	1	5	119
🪟 Windows	381	3	0	119

Summary: 767 passed, 4 failed, 5 flaky, 238 skipped

Failed Tests

🍎 macOS

package_manager.spec.ts > custom pnpm install auto-denies ignored builds and recovers preview
- Test timeout of 360000ms exceeded.

🪟 Windows

edit_code.spec.ts > edit code edits the right file during rapid switches
- Error: expect(received).toEqual(expected) // deep equality
package_manager.spec.ts > custom pnpm install auto-denies ignored builds and recovers preview
- Test timeout of 360000ms exceeded.
template-create-nextjs.spec.ts > create next.js app
- Error: expect(locator).toBeEnabled() failed

📋 Re-run Failing Tests (macOS)

Copy and paste to re-run all failing spec files locally:

npm run e2e \
  e2e-tests/package_manager.spec.ts

⚠️ Flaky Tests

🍎 macOS

engine.spec.ts > send message to engine (passed after 1 retry)
fix_error.spec.ts > copy error message from banner (passed after 1 retry)
smart_context_balanced.spec.ts > smart context balanced - simple (passed after 1 retry)
smart_context_deep.spec.ts > smart context deep - read write read (passed after 1 retry)
visual_editing.spec.ts > swap image via URL (passed after 1 retry)

📊 View full report

keppo-bot Bot requested a review from a team July 9, 2026 00:47

keppo-bot Bot temporarily deployed to ai-bots July 9, 2026 00:47 Inactive

keppo-bot Bot had a problem deploying to ai-bots July 9, 2026 00:47 Failure

keppo-bot Bot temporarily deployed to ai-bots July 9, 2026 00:48 Inactive

keppo-bot Bot temporarily deployed to ai-bots July 9, 2026 00:53 Inactive

github-actions Bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Jul 9, 2026

keppo-bot Bot removed the needs-human:review-issue ai agent flagged an issue that requires human review label Jul 9, 2026

keppo-bot Bot had a problem deploying to ai-bots July 9, 2026 01:06 Failure

keppo-bot Bot temporarily deployed to ai-bots July 9, 2026 01:06 Inactive

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/pro/main/ipc/handlers/local_agent/tools/run_type_checks.ts

keppo-bot Bot temporarily deployed to ai-bots July 9, 2026 01:14 Inactive

dyad-assistant Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/ipc/handlers/problems_handlers.ts

Comment thread src/ipc/processors/tsc.ts

github-actions Bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Jul 9, 2026

wwwillchen removed the needs-human:review-issue ai agent flagged an issue that requires human review label Jul 9, 2026

wwwillchen temporarily deployed to ai-bots July 9, 2026 02:39 — with GitHub Actions Inactive

wwwillchen had a problem deploying to ai-bots July 9, 2026 02:39 — with GitHub Actions Error

wwwillchen had a problem deploying to ai-bots July 9, 2026 02:39 — with GitHub Actions Failure

wwwillchen added 4 commits July 8, 2026 19:44

fix: handle unavailable TypeScript checks

edb8a73

fix: address typecheck guidance review

2f98055

Address PR review comments

0c08cd5

- Gate type-check dependency guidance on add_dependency availability - Guard problem precondition guidance before appPath is assigned - Document preserved DyadError classification

fix

e616880

wwwillchen force-pushed the update-agent-docs-20260708174741 branch from d016dc3 to e616880 Compare July 9, 2026 02:47

wwwillchen temporarily deployed to ai-bots July 9, 2026 02:47 — with GitHub Actions Inactive

wwwillchen had a problem deploying to ai-bots July 9, 2026 02:47 — with GitHub Actions Failure

wwwillchen had a problem deploying to ai-bots July 9, 2026 02:47 — with GitHub Actions Error

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

simplify

c9b8646

wwwillchen temporarily deployed to ai-bots July 9, 2026 02:52 — with GitHub Actions Inactive

wwwillchen had a problem deploying to ai-bots July 9, 2026 02:52 — with GitHub Actions Failure

wwwillchen temporarily deployed to ai-bots July 9, 2026 02:53 — with GitHub Actions Inactive

wwwillchen temporarily deployed to ai-bots July 9, 2026 03:01 — with GitHub Actions Inactive

github-actions Bot added the needs-human:review-issue ai agent flagged an issue that requires human review label Jul 9, 2026

wwwillchen merged commit 6d32fe1 into main Jul 9, 2026
21 of 23 checks passed

wwwillchen deleted the update-agent-docs-20260708174741 branch July 9, 2026 04:22

Uh oh!

Conversation

keppo-bot Bot commented Jul 9, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

wwwillchen commented Jul 9, 2026

Uh oh!

dyad-assistant Bot commented Jul 9, 2026

🔍 Dyadbot Code Review Summary

Issues Summary

Uh oh!

wwwillchen commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dyad-assistant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dyad-assistant Bot commented Jul 9, 2026

🔍 Dyadbot Code Review Summary

Issues Summary

Uh oh!

wwwillchen commented Jul 9, 2026

Uh oh!

wwwillchen commented Jul 9, 2026

🤖 Claude Code Review Summary

PR Confidence: 5/5

Unresolved Threads

Resolved Threads

Uh oh!

wwwillchen commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

wwwillchen commented Jul 9, 2026

Uh oh!

dyad-assistant Bot commented Jul 9, 2026

🔍 Dyadbot Code Review Summary

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

🎭 Playwright Test Results

❌ Some tests failed

Failed Tests

🍎 macOS

🪟 Windows

📋 Re-run Failing Tests (macOS)

⚠️ Flaky Tests

🍎 macOS

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

keppo-bot Bot commented Jul 9, 2026 •

edited by cubic-dev-ai Bot

Loading