Skip to content

fix: resolve BeanPostProcessors auto-proxy warning (#257) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fhui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve BeanPostProcessors auto-proxy warning (#257) #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions ...ring-boot-starter/src/main/java/com/dtflys/forest/springboot/ForestAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,15 @@
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.DependsOn;
import org.springframework.context.annotation.Import;
import org.springframework.context.annotation.Role;

import javax.annotation.Resource;

@Configuration
@EnableConfigurationProperties({ForestConfigurationProperties.class})
@Import({ForestScannerRegister.class})
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public class ForestAutoConfiguration {

@Resource
private ConfigurableApplicationContext applicationContext;

@Bean
@ConditionalOnMissingBean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
Expand All @@ -51,28 +45,25 @@ public SpringInterceptorFactory forestInterceptorFactory() {


@Bean
@DependsOn("forestBeanProcessor")
@ConditionalOnMissingBean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public ForestBeanRegister forestBeanRegister(SpringForestProperties properties,
SpringForestObjectFactory forestObjectFactory,
SpringInterceptorFactory forestInterceptorFactory,
ForestConfigurationProperties forestConfigurationProperties) {
ForestBeanRegister register = new ForestBeanRegister(
public static ForestBeanRegister forestBeanRegister(ConfigurableApplicationContext applicationContext,
SpringForestProperties properties,
SpringForestObjectFactory forestObjectFactory,
SpringInterceptorFactory forestInterceptorFactory,
ForestConfigurationProperties forestConfigurationProperties) {
return new ForestBeanRegister(
applicationContext,
forestConfigurationProperties,
properties,
forestObjectFactory,
forestInterceptorFactory);
register.registerForestConfiguration();
register.registerScanner();
return register;
}

@Bean
@ConditionalOnMissingBean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public ForestBeanProcessor forestBeanProcessor() {
public static ForestBeanProcessor forestBeanProcessor() {
return new ForestBeanProcessor();
}

Expand Down
25 changes: 13 additions & 12 deletions ...st-spring-boot-starter/src/main/java/com/dtflys/forest/springboot/ForestBeanRegister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
import com.dtflys.forest.springboot.properties.ForestSSLKeyStoreProperties;
import com.dtflys.forest.utils.ForestDataType;
import com.dtflys.forest.utils.StringUtils;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
import org.springframework.beans.factory.support.ManagedMap;
import org.springframework.cglib.core.ReflectUtils;
import org.springframework.context.ConfigurableApplicationContext;
Expand All @@ -39,7 +39,7 @@
import java.util.Map;
import java.util.stream.Collectors;

public class ForestBeanRegister implements ResourceLoaderAware, BeanPostProcessor {
public class ForestBeanRegister implements ResourceLoaderAware, BeanDefinitionRegistryPostProcessor {

private final ConfigurableApplicationContext applicationContext;

Expand Down Expand Up @@ -71,6 +71,16 @@ public void setResourceLoader(ResourceLoader resourceLoader) {
this.resourceLoader = resourceLoader;
}

@Override
public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) {
registerForestConfiguration();
registerScanner();
}

@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) {
}


public ForestConfiguration registerForestConfiguration() {
BeanDefinitionBuilder beanDefinitionBuilder = BeanDefinitionBuilder.genericBeanDefinition(ForestConfiguration.class);
Expand Down Expand Up @@ -296,13 +306,4 @@ public ClassPathClientScanner registerScanner() {
return scanner;
}

@Override
public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
return bean;
}

@Override
public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
return bean;
}
}
19 changes: 7 additions & 12 deletions ...ing-boot3-starter/src/main/java/com/dtflys/forest/springboot/ForestAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.DependsOn;
import org.springframework.context.annotation.Import;
import org.springframework.context.annotation.Role;

Expand Down Expand Up @@ -46,29 +45,25 @@ public SpringInterceptorFactory forestInterceptorFactory() {


@Bean
@DependsOn("forestBeanProcessor")
@ConditionalOnMissingBean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public ForestBeanRegister forestBeanRegister(ConfigurableApplicationContext applicationContext,
SpringForestProperties properties,
SpringForestObjectFactory forestObjectFactory,
SpringInterceptorFactory forestInterceptorFactory,
ForestConfigurationProperties forestConfigurationProperties) {
ForestBeanRegister register = new ForestBeanRegister(
public static ForestBeanRegister forestBeanRegister(ConfigurableApplicationContext applicationContext,
SpringForestProperties properties,
SpringForestObjectFactory forestObjectFactory,
SpringInterceptorFactory forestInterceptorFactory,
ForestConfigurationProperties forestConfigurationProperties) {
return new ForestBeanRegister(
applicationContext,
forestConfigurationProperties,
properties,
forestObjectFactory,
forestInterceptorFactory);
register.registerForestConfiguration();
register.registerScanner();
return register;
}

@Bean
@ConditionalOnMissingBean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
public ForestBeanProcessor forestBeanProcessor() {
public static ForestBeanProcessor forestBeanProcessor() {
return new ForestBeanProcessor();
}

Expand Down
25 changes: 13 additions & 12 deletions ...t-spring-boot3-starter/src/main/java/com/dtflys/forest/springboot/ForestBeanRegister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
import com.dtflys.forest.springboot.properties.ForestSSLKeyStoreProperties;
import com.dtflys.forest.utils.ForestDataType;
import com.dtflys.forest.utils.StringUtils;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.beans.factory.support.ManagedMap;
Expand All @@ -38,7 +38,7 @@
import java.util.List;
import java.util.Map;

public class ForestBeanRegister implements ResourceLoaderAware, BeanPostProcessor {
public class ForestBeanRegister implements ResourceLoaderAware, BeanDefinitionRegistryPostProcessor {

private final ConfigurableApplicationContext applicationContext;

Expand Down Expand Up @@ -70,6 +70,16 @@ public void setResourceLoader(ResourceLoader resourceLoader) {
this.resourceLoader = resourceLoader;
}

@Override
public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) {
registerForestConfiguration();
registerScanner();
}

@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) {
}


public ForestConfiguration registerForestConfiguration() {
BeanDefinitionBuilder beanDefinitionBuilder = BeanDefinitionBuilder.genericBeanDefinition(ForestConfiguration.class);
Expand Down Expand Up @@ -294,13 +304,4 @@ public ClassPathClientScanner registerScanner() {
return scanner;
}

@Override
public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
return bean;
}

@Override
public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
return bean;
}
}
55 changes: 55 additions & 0 deletions ...ot3-test/src/test/java/com/dtflys/forest/springboot3/test/ForestAutoProxyWarningTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package com.dtflys.forest.springboot3.test;

import ch.qos.logback.classic.Level;
import ch.qos.logback.classic.Logger;
import ch.qos.logback.classic.spi.ILoggingEvent;
import ch.qos.logback.core.read.ListAppender;
import com.dtflys.forest.springboot.annotation.ForestScannerRegister;
import org.junit.Test;
import org.slf4j.LoggerFactory;
import org.springframework.boot.WebApplicationType;
import org.springframework.boot.autoconfigure.AutoConfigurationPackage;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.builder.SpringApplicationBuilder;
import org.springframework.boot.context.event.ApplicationFailedEvent;
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.context.annotation.Configuration;

import static org.junit.Assert.assertFalse;

public class ForestAutoProxyWarningTest extends BaseSpringBootTest {

@Test
public void testNoBeanPostProcessorCheckerWarning() {
Logger logger = (Logger) LoggerFactory.getLogger(
"org.springframework.context.support.PostProcessorRegistrationDelegate$BeanPostProcessorChecker");
ListAppender<ILoggingEvent> appender = new ListAppender<>();
appender.start();
logger.addAppender(appender);
Level level = logger.getLevel();
logger.setLevel(Level.INFO);

try (ConfigurableApplicationContext ignored = new SpringApplicationBuilder(TestApplication.class)
.web(WebApplicationType.NONE)
.listeners(event -> {
if (event instanceof ApplicationFailedEvent) {
ForestScannerRegister.cleanBackPackages();
}
})
.run("--spring.main.banner-mode=off")) {
assertFalse(appender.list.stream()
.map(ILoggingEvent::getFormattedMessage)
.anyMatch(message -> message.contains("not eligible for getting processed by all BeanPostProcessors")
&& message.contains("forestBeanProcessor")));
} finally {
logger.detachAppender(appender);
logger.setLevel(level);
}
}

@Configuration
@EnableAutoConfiguration
@AutoConfigurationPackage
static class TestApplication {
}
}