fix: date filter and status defaults for v1.6.2 - #12
Merged
Merged
Conversation
- Update package.json version - Update Dockerfile version label - Update MCP server version in source code - Update mcp.json version - Update MCPB manifest version - Automated version bump for release
- Replace modifiedSince with createdAt query syntax for accurate creation date filtering - Add appendCreatedAtFilter helper to consistently apply date ranges via query syntax - Fix advancedConversationSearch to default to status=all instead of omitting param - Fix structuredConversationFilter to send status=all for ticket number lookups - Update integration tests to match new query format
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Validate ISO 8601 format in appendCreatedAtFilter to prevent query injection - Strip milliseconds to match Help Scout expectations - Remove explicit undefined args and duplicate comments at all call sites - Standardize status default expression to input.status || 'all' - Fix version assertion in index.test.ts for v1.6.2
mkeizer
added a commit
to mkeizer/help-scout-mcp-server
that referenced
this pull request
May 5, 2026
…playbook Core rule added after test-lab matrix on ticket 1288666 (21:20): all 3 models (Haiku/Sonnet/Opus) failed the evening closing — Haiku+Opus used "Fijne dag!" past 18:00, Sonnet used "Goedenavond!" as farewell (that's a greeting). New Step 0 anti-pattern drewburchfield#12/#13 + expanded closing rules in both triage.md and the antipatterns-top overlay. Also lands: ssh-access.md rewrite (gateway first, direct SSH as rare escape hatch), refined dry-run SSH hook (matches command invocation, not text mentions), matrix-report.md (10-run analysis), extra configs for the antipatterns-top matrix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modifiedSinceAPI param withcreatedAtquery syntax across 4 tools (searchConversations, comprehensiveConversationSearch, advancedConversationSearch, structuredConversationFilter). Help Scout'smodifiedSincefilters by last modification date, not creation date, causing silent 0-result returns.status=allinstead of omitting the param (API defaults to active-only when omitted)status=allfor ticket number lookups so closed/pending tickets are foundTest plan