🎨 Palette: Accessibility and UX improvements for Modals#99
🎨 Palette: Accessibility and UX improvements for Modals#99google-labs-jules[bot] wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…nager db_path - Update pyproject.toml to pin elevenlabs<3.0 (from <4.0) to resolve `ImportError: cannot import name 'ElevenLabs' from 'elevenlabs.client'` - Remove deprecated `db_path` argument from `VisionRAGManager` instantiations in test cases to resolve test suite failures. - Fix imports in `live_chat_app.py` and `voice_toggle.py` to match the `<3.0` API (`from elevenlabs.client import ElevenLabs`).
💡 What: Added semantic attributes (
role="dialog",aria-modal="true",aria-label) and global Escape key support to custom modals (#screenshotModal,#pickerModal,#systemMapModal).🎯 Why: Improves keyboard navigation and screen reader accessibility. Users can now intuitively dismiss modals using the
Escapekey, a standard UX pattern that was previously missing.📸 Before/After: Verified visually via Playwright script (visual layout undisturbed, Escape successfully dismisses modals).
♿ Accessibility: Enhanced screen reader compatibility and keyboard operability.
PR created automatically by Jules for task 10477197675135583745 started by @dqikfox