Fix CuriosityEngine error handling missing task_done()#98
Fix CuriosityEngine error handling missing task_done()#98google-labs-jules[bot] wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The
CuriosityEngineclass uses anasyncio.Queue(self._queue) to store topics for self-research. In its backgroundrun()loop, it retrieves topics usingself._queue.get(). However, it never calledself._queue.task_done()after processing a topic, neither on success nor on failure.When an item is retrieved from an
asyncio.Queuewith.get(), the queue considers the item as still "being processed" until.task_done()is called. This meant that if another part of the system attempts to wait for the queue to empty usingawait self._queue.join(), it would block forever.The fix adds a
finallyblock to the processing loop to ensureself._queue.task_done()is called regardless of whether the processing succeeded or failed. Tests have been added to verify this.PR created automatically by Jules for task 6454238919304145721 started by @dqikfox