Skip to content

Fix CuriosityEngine error handling missing task_done()#98

Draft
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
jules-6454238919304145721-4859b670
Draft

Fix CuriosityEngine error handling missing task_done()#98
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
jules-6454238919304145721-4859b670

Conversation

@google-labs-jules

Copy link
Copy Markdown

The CuriosityEngine class uses an asyncio.Queue (self._queue) to store topics for self-research. In its background run() loop, it retrieves topics using self._queue.get(). However, it never called self._queue.task_done() after processing a topic, neither on success nor on failure.

When an item is retrieved from an asyncio.Queue with .get(), the queue considers the item as still "being processed" until .task_done() is called. This meant that if another part of the system attempts to wait for the queue to empty using await self._queue.join(), it would block forever.

The fix adds a finally block to the processing loop to ensure self._queue.task_done() is called regardless of whether the processing succeeded or failed. Tests have been added to verify this.


PR created automatically by Jules for task 6454238919304145721 started by @dqikfox

@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vision Ready Ready Preview, Comment Jun 30, 2026 2:05am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants