🎨 Palette: Accessible UI Modals and Keyboard Enhancements#96
🎨 Palette: Accessible UI Modals and Keyboard Enhancements#96google-labs-jules[bot] wants to merge 3 commits into
Conversation
- Added `role="dialog"` and `aria-modal="true"` to `screenshotModal`, `pickerModal`, and `systemMapModal` to improve screen reader compatibility. - Added explicit `aria-label`s to all modal close buttons. - Converted `#screenshotModal`'s close element from a `div` to a semantically correct `button`. - Added a global document-level `keydown` event listener to gracefully close active modals on `Escape` key presses, fixing keyboard navigation lock-in issues. - Documented these accessible modal patterns in `.Jules/palette.md` for future reference.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…nings Also includes accessible modal enhancements from the previous commit since we reverted local `pyproject.toml` changes that broke the test suite.
…dependencies Also includes accessible modal enhancements from the previous commit since we reverted local `pyproject.toml` changes that broke the test suite.
This PR introduces critical micro-UX accessibility improvements to the custom overlay modals in
live_chat_ui.html. By adding missing semantic ARIA roles, ensuring screen readers can announce the modal focus, converting non-semantic closure divs tobuttontags witharia-labels, and most importantly, adding globalEscapekey dismissal functionality, this ensures users are no longer trapped inside overlay interfaces if they navigate exclusively by keyboard.These changes are constrained entirely to the frontend HTML/JS, use existing CSS patterns, and have been tested both natively and via Playwright execution tests to confirm overlay state functionality without introducing regressions to core workflows.
PR created automatically by Jules for task 15271072020089856340 started by @dqikfox