🎨 Palette: Modal accessibility and escape dismissal#92
🎨 Palette: Modal accessibility and escape dismissal#92google-labs-jules[bot] wants to merge 3 commits into
Conversation
- Added `role="dialog"` and `aria-modal="true"` to semantic modals - Replaced div close handlers with semantic `<button>` tags - Added explicit `aria-label` attributes to icon-only buttons - Added global `Escape` key event listener for modal dismissal
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Fixes Node 20 deprecation warnings in CI workflows. - Upgrades `actions/setup-python@v4` to `actions/setup-python@v5` in `.github/workflows/quality.yml` and `.github/workflows/main_vision.yml`.
- Added `role="dialog"` and `aria-modal="true"` to semantic modals - Replaced div close handlers with semantic `<button>` tags - Added explicit `aria-label` attributes to icon-only buttons - Added global `Escape` key event listener for modal dismissal - Includes separate commits to upgrade GitHub Actions `setup-python` node definitions and relax strict pip dependency bounds for CI test execution.
This PR implements standard accessibility features across the application's modals.
role="dialog",aria-modal="true")<button>sEscapekey dismissal for open overlaysaria-labels on icon-only and ambiguous inputs like the screenshot button, agent button, and memory additions.PR created automatically by Jules for task 14320064791687987119 started by @dqikfox