🎨 Palette: Modal Keyboard Accessibility & ARIA enhancements#101
🎨 Palette: Modal Keyboard Accessibility & ARIA enhancements#101google-labs-jules[bot] wants to merge 4 commits into
Conversation
- Convert non-semantic <div> close buttons to <button> - Add aria-label="Close" to all icon-only ✕ modal close buttons - Add Escape key event listener to globally close modals (UX micro-enhancement for keyboard a11y)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Convert non-semantic <div> close buttons to <button> - Add aria-label="Close" to all icon-only ✕ modal close buttons - Add Escape key event listener to globally close modals - Fix CI by upgrading setup-python action to v5 - Fix CI by correcting pynvml dependency version (UX micro-enhancement for keyboard a11y)
- Convert non-semantic <div> close buttons to <button> - Add aria-label="Close" to all icon-only ✕ modal close buttons - Add Escape key event listener to globally close modals - Fix CI by upgrading setup-python action to v5 - Fix CI by correcting pynvml dependency version - Fix CI by correcting elevenlabs import statement (UX micro-enhancement for keyboard a11y)
- Convert non-semantic <div> close buttons to <button> - Add aria-label="Close" to all icon-only ✕ modal close buttons - Add Escape key event listener to globally close modals - Fix CI by upgrading setup-python action to v5 - Fix CI by correcting pynvml dependency version - Fix CI by restricting elevenlabs to <3.0 to resolve import issues (UX micro-enhancement for keyboard a11y)
💡 What: The UX enhancement added semantic tags, missing
aria-labels, and anEscapekey close listener to custom modals (screenshotModal,pickerModal,systemMapModal).🎯 Why: Custom overlays and modals require explicit aria labels and standard keyboard shortcuts (like
Escape) to ensure accessibility for screen readers and keyboard users.📸 Before/After: Tested via local Playwright script showing expected closure of modals upon
Escapekeydown.♿ Accessibility: Added missing attributes to ensure WAI-ARIA modal dialogue pattern best practices.
PR created automatically by Jules for task 12908026000549755634 started by @dqikfox