fix(mlxlm): guard generate_batch output_type with 'is not None' - #1999
Open
eeshsaxena wants to merge 1 commit into
Open
fix(mlxlm): guard generate_batch output_type with 'is not None'#1999eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLXLMModel.generate_batchguards against structured generation (which mlx-lm can't do with batching) using a truthy check:Every other place in the codebase that inspects
output_typeuses an identity check (is None/is not None); this is the onlyif output_type:in the repo. The difference matters here: if anoutput_typeis provided that happens to be falsy, for example an object whose__bool__returnsFalse, the guard is skipped andbatch_generateruns with no constraint. The caller asked for structured output and silently gets unconstrained text instead of theNotImplementedErrorthey should get.Switching to
is not Nonemakes the guard fire for any provided output type and matches the convention used everywhere else.The mlxlm test module is gated behind
@pytest.mark.skipif(not HAS_MLX, ...)and needs a real model, so there is no CI-runnable spot to add a case; this is a one-line guard correction that can't change theNone(default) or normal-object paths.