fix: forward falsy logits processor in mlxlm format_output_type - #1995
Open
serhiizghama wants to merge 2 commits into
Open
fix: forward falsy logits processor in mlxlm format_output_type#1995serhiizghama wants to merge 2 commits into
serhiizghama wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1980.
MLXLMTypeAdapter.format_output_typeusedif not output_typeto decide whether a logits processor was supplied. That's a truthiness check, so any processor whose__bool__(or__len__) evaluates toFalsegets silently dropped and generation runs unconstrained — no error, just wrong output. OnlyNoneshould mean "no constraint".Switched to the identity check
if output_type is not None, matchingtransformers.py,llamacpp.pyand the other backends.Added two tests that don't need Apple Silicon (they build the adapter with a mock tokenizer): one for the
Nonecase and one for a falsy processor. The falsy-processor test fails on the old code and passes on the fix.