fix(applications): make output_type, model and generator private - #1990
Open
harsh4vardhan wants to merge 1 commit into
Open
fix(applications): make output_type, model and generator private#1990harsh4vardhan wants to merge 1 commit into
harsh4vardhan wants to merge 1 commit into
Conversation
output_type, model, and generator are internal implementation details — making them private prevents users from mutating output_type after construction, which is the root cause of the stale-generator bug reported in dottxt-ai#1982. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1982
What
Makes , , and private attributes (prefixed with ) on the class.
Why
As suggested by @RobinPicard in #1982: rather than adding defensive cache-invalidation logic to detect when changes after construction, making the attribute private removes the invalid state entirely — users can no longer mutate it after construction, so the stale-generator scenario cannot occur.
and are made private too since they are internal caching state, not part of the public API.
Changes