Skip to content

fix(mlxlm): check if output_type is None instead of truthiness #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aryan-Pardeshi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mlxlm): check if output_type is None instead of truthiness #1987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e3589
fix(mlxlm): use an identity-None check in format_output_type
Aryan-Pardeshi Aug 7, 2026
f576f91
test(mlxlm): remove synthetic falsy-processor and None coverage
Aryan-Pardeshi Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/outlines/models/mlxlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def format_output_type(
The logits processor argument to be passed to the model.

"""
if not output_type:
if output_type is None:
return None
return [output_type]

Expand Down
23 changes: 23 additions & 0 deletions tests/models/test_mlxlm_type_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,29 @@ def test_mlxlm_type_adapter_format_input(adapter, image):
]))


def test_mlxlm_type_adapter_format_output_type_falsy_processor():
tokenizer = MagicMock()
adapter = MLXLMTypeAdapter(tokenizer=tokenizer)

class FalsyProcessor:
def __bool__(self):
return False

processor = FalsyProcessor()
result = adapter.format_output_type(processor)

assert result == [processor]


def test_mlxlm_type_adapter_format_output_type_none():
tokenizer = MagicMock()
adapter = MLXLMTypeAdapter(tokenizer=tokenizer)

result = adapter.format_output_type(None)

assert result is None


@pytest.mark.skipif(not HAS_MLX, reason="MLX tests require Apple Silicon")
def test_mlxlm_type_adapter_format_output_type(adapter, logits_processor):
formatted = adapter.format_output_type(logits_processor)
Expand Down