Skip to content

Emit {0,n} for at_most so the regex compiles on the outlines-core backend #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lollinng wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Emit {0,n} for at_most so the regex compiles on the outlines-core backend #1871

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d065f
Emit {0,n} for at_most so the regex compiles on outlines-core
lollinng Jun 5, 2026
802114b
Update test_to_regex_simple for {0,n} at_most output
lollinng Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion outlines/types/dsl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ def to_regex(term: Term) -> str:
elif isinstance(term, QuantifyMinimum):
return f"({to_regex(term.term)}){{{term.min_count},}}"
elif isinstance(term, QuantifyMaximum):
return f"({to_regex(term.term)}){{,{term.max_count}}}"
return f"({to_regex(term.term)}){{0,{term.max_count}}}"
elif isinstance(term, QuantifyBetween):
return f"({to_regex(term.term)}){{{term.min_count},{term.max_count}}}"
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/types/test_dsl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ def test_to_regex():
assert to_regex(min_term) == r"(a){2,}"

max_term = QuantifyMaximum(String("a"), 5)
assert to_regex(max_term) == r"(a){,5}"
assert to_regex(max_term) == r"(a){0,5}"

between_term = QuantifyBetween(String("a"), 1, 3)
assert to_regex(between_term) == r"(a){1,3}"
Expand Down
Loading