Add support for reasoning models#1711
Draft
RobinPicard wants to merge 1 commit into
Draft
Conversation
rlouf
reviewed
Aug 6, 2025
| The tag the model uses to indicate the end of the thinking process. | ||
| Only used when running a thinking model. | ||
| thinking_max_tokens: int | None | ||
| The maximum number of tokens the model can think about. Only used when |
Member
There was a problem hiding this comment.
Suggested change
| The maximum number of tokens the model can think about. Only used when | |
| The maximum number of tokens the model can think for. Only used when |
rlouf
reviewed
Aug 6, 2025
Comment on lines
+41
to
+44
| end_thinking_token_id: int | None | ||
| The id of the end thinking token | ||
| thinking_max_tokens: int | None | ||
| The maximum number of tokens the model can think about |
Member
There was a problem hiding this comment.
Isn't it possible to only build a specialized logits processor that the backends are unaware of? You should be able to not call the logits biasing function as long as </think> has not been generated, and limit the number of tokens from the logits processor.
Contributor
Author
There was a problem hiding this comment.
Initially I wanted to wrap the logits processor into another one that would just not bias anything until we encounter the token and then it calls the other tokenizer it wraps, the problem is that it does not work for batching as the different sequences may not all stop thinking at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose 2 new keywords for generation:
end_thinking_tag: a string indicating the tag used by the reasoning model to indicate that thinking is finished (and so that we should start constraining the generation)thinking_max_tokens: an int giving the maximum number of tokens during which the model can think, after that number is reached, we force the generation of the end of thinking tokenNot supported:
If we want to capture the content of the thinking in the future when we will return an object with various attributes instead of just the text output, we could add an argument
start_thinking_tagfor the models that use one.