Extract file-based app entry point heuristic#84385
Draft
mwiemer-microsoft wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the file-based program “entry point” classification logic in the Language Server by extracting it into a shared internal heuristic, and adds focused unit tests to validate explicit, ambiguous, and non-entry-point outcomes.
Changes:
- Introduces
FileBasedProgramEntryPointKindandFileBasedProgramEntryPointHeuristic.GetEntryPointKind(...)to centralize entry-point classification. - Updates
FileBasedProgramsProjectSystem.ClassifyDocumentAsyncto use the extracted heuristic while preserving the existing option-gated “ambiguous entry point” behavior. - Adds a new theory to unit test the heuristic across representative inputs (shebang,
#:directives, top-level statements, and non-entry-point cases).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/FileBasedPrograms/FileBasedProgramsProjectSystem.cs | Extracts entry-point classification into an internal heuristic and rewires document classification to use it. |
| src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/MiscellaneousFiles/FileBasedProgramsEntryPointDiscoveryTests.cs | Adds direct unit coverage for the new heuristic’s explicit/ambiguous/none outcomes. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet build src\LanguageServer\Microsoft.CodeAnalysis.LanguageServer\Microsoft.CodeAnalysis.LanguageServer.csproj --no-restoredotnet test src\LanguageServer\Microsoft.CodeAnalysis.LanguageServer.UnitTests\Microsoft.CodeAnalysis.LanguageServer.UnitTests.csproj --filter "FullyQualifiedName~FileBasedProgramsEntryPointDiscoveryTests" --no-restoreMicrosoft Reviewers: Open in CodeFlow