Downgrade "No callback for response message" from Warning to Debug in OutsideRuntimeClient - #9950
Merged
Merged
Conversation
…utsideRuntimeClient Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Convert frequent warning logs to debug logs
Downgrade "No callback for response message" from Warning to Debug in OutsideRuntimeClient
Feb 26, 2026
Member
|
@copilot Also make this change in InsideRuntimeClient |
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts logging in OutsideRuntimeClient to reduce expected warning noise when clients cancel IAsyncEnumerable enumerations and a late response arrives without a registered callback.
Changes:
- Downgrade “No callback for response message …” log from
WarningtoDebuginOutsideRuntimeClient. - Rename the logger helper method to reflect the new log level (
LogWarning…→LogDebug…).
ReubenBond
approved these changes
Feb 26, 2026
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
… OutsideRuntimeClient (dotnet#9950) * Initial plan * Convert 'No callback for response message' from Warning to Debug in OutsideRuntimeClient Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ReubenBond <203839+ReubenBond@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client cancels an
IAsyncEnumerableenumerator, the server still sends a response after the client has already removed the callback — producing frequent, noisyWarninglogs that are entirely expected behavior.Changes
OutsideRuntimeClient.cs: Change log level for "No callback for response message" fromLogLevel.Warning→LogLevel.Debug, matching the identical log already atDebuginInsideRuntimeClient.cs. Renamed method fromLogWarningNoCallbackForResponseMessage→LogDebugNoCallbackForResponseMessagefor consistency.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.
Microsoft Reviewers: Open in CodeFlow