perf(serialization): avoid delimiter array allocations - #10966
Merged
ReubenBond merged 1 commit intoSep 2, 2026
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a small, low-risk allocation optimization which preserves the same delimiter sets and has no remaining usage of the removed member.
Review tier: Lite
Findings: None
What changed in this PR
This PR optimizes RuntimeTypeNameParser in Orleans.Serialization by removing short-lived char[] allocations when accessing delimiter spans during runtime type-name parsing.
Changes:
- Replaced delimiter-span properties which allocated
new char[] { ... }withReadOnlySpan<char>backed by string literals. - Removed the unused
TupleDelimitersproperty.
| File | Description |
|---|---|
| src/Orleans.Serialization/TypeSystem/RuntimeTypeNameParser.cs | Eliminates delimiter array allocations by switching span sources to string literals and removes an unused delimiter property. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeTypeNameParser currently creates a new character array whenever its delimiter spans are accessed. Every named type segment uses the type-name delimiters, with additional arrays created for assembly-qualified names and compound alias literals.\n\nBack the delimiter spans with string literals and remove the unused tuple delimiter property. This preserves parsing behavior while eliminating short-lived array allocations from type-name parsing.
Microsoft Reviewers: Open in CodeFlow