perf(grain): lazily resolve grain runtime#10117
Draft
ReubenBond wants to merge 1 commit into
Draft
Conversation
Avoid storing an IGrainRuntime reference on every Grain instance until it is needed, and resolve the shared runtime from GrainTypeSharedContext without adding an activation component. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid storing an
IGrainRuntimereference on everyGraininstance until it is needed.The runtime is resolved from the shared grain type context when available, preserving the existing direct-construction behavior for tests and non-runtime-created grains.
Validation:
dotnet build src\Orleans.Runtime\Orleans.Runtime.csproj --nologo --verbosity:minimalMicrosoft Reviewers: Open in CodeFlow