Skip to content

Switch order of literals to prevent NullPointerException #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixeebot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch order of literals to prevent NullPointerException #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/donlaiq/coin/CryptoCoin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ public static CryptoCoin getCryptoCoin()
*/
public static CryptoCoin getCryptoCoin(String cryptoName)
{
if(cryptoName.equals("Qtum"))
if("Qtum".equals(cryptoName))
cryptoCoin = new Qtum();
else if(cryptoName.equals("ZCash"))
else if("ZCash".equals(cryptoName))
cryptoCoin = new ZCash();
else if(cryptoName.equals("Bitcoin Core"))
else if("Bitcoin Core".equals(cryptoName))
cryptoCoin = new BitcoinCore();
else
cryptoCoin = new BitcoinZ();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/donlaiq/controller/WalletController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ private void updateFromBlockchain()
if(percentage.length() > 5)
percentage = percentage.substring(0, 5);

if(!percentage.equals(""))
if(!"".equals(percentage))
{
if(Double.valueOf(percentage) < 99.99)
{
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/donlaiq/controller/setup/CommandController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void loadProperties()

getBlockChainInfo.setText(choseProperties.get("get.blockchain.info"));
sendMany.setText(choseProperties.get("send.many"));
if(choseProperties.get("two.kind.of.addresses").equals("true"))
if("true".equals(choseProperties.get("two.kind.of.addresses")))
{
if(choseProperties.get("z.list.addresses") != null)
{
Expand Down Expand Up @@ -92,7 +92,7 @@ public void loadProperties()
getBlockChainInfo.setText(globalProperties.get("get.blockchain.info"));
sendMany.setText(globalProperties.get("send.many"));

if(choseProperties.get("two.kind.of.addresses").equals("true"))
if("true".equals(choseProperties.get("two.kind.of.addresses")))
{
zListAddresses.setText(globalProperties.get("z.list.addresses"));
zGetBalance.setText(globalProperties.get("z.get.balance"));
Expand Down Expand Up @@ -121,7 +121,7 @@ protected void updateMap()
choseProperties.put("get.blockchain.info", getBlockChainInfo.getText());
choseProperties.put("send.many", sendMany.getText());

if(choseProperties.get("two.kind.of.addresses").equals("true"))
if("true".equals(choseProperties.get("two.kind.of.addresses")))
{
choseProperties.put("z.list.addresses", zListAddresses.getText());
choseProperties.put("z.get.balance", zGetBalance.getText());
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/donlaiq/controller/setup/GeneralController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void loadProperties()

isTwoKindOfAddresses.getItems().setAll("True", "False");

if(choseProperties.get("two.kind.of.addresses").equals("true"))
if("true".equals(choseProperties.get("two.kind.of.addresses")))
isTwoKindOfAddresses.getSelectionModel().select(0);
else
isTwoKindOfAddresses.getSelectionModel().select(1);
Expand Down Expand Up @@ -123,7 +123,7 @@ public void loadProperties()

isTwoKindOfAddresses.getItems().setAll("True", "False");

if(globalProperties.get("two.kind.of.addresses").equals("false"))
if("false".equals(globalProperties.get("two.kind.of.addresses")))
isTwoKindOfAddresses.getSelectionModel().select(1);
else
isTwoKindOfAddresses.getSelectionModel().select(0);
Expand Down Expand Up @@ -220,7 +220,7 @@ private void setPresetCoin()
foreignLanguage.setText(choseProperties.get("foreign.language"));
donateAddress.setText(choseProperties.get("donate.address"));

if(choseProperties.get("two.kind.of.addresses").equals("false"))
if("false".equals(choseProperties.get("two.kind.of.addresses")))
isTwoKindOfAddresses.getSelectionModel().select(1);
else
isTwoKindOfAddresses.getSelectionModel().select(0);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/donlaiq/controller/setup/NodeController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public void updateMap()
@Override
protected void setPaths()
{
if(choseProperties.get("two.kind.of.addresses").equals("true"))
if("true".equals(choseProperties.get("two.kind.of.addresses")))
fxmlPathNext = "/resources/fxml/command_setup_z.fxml";
else
fxmlPathNext = "/resources/fxml/command_setup_t.fxml";
Expand Down