feat: share acme account across apps#409
Merged
Merged
Conversation
The lego accounts directory is now mounted from a shared host path so apps configured with the same `email` and `server` reuse a single ACME account instead of each registering its own. This sidesteps the Let's Encrypt 10-new-accounts-per-IP-per-3-hours limit for hosts adding HTTPS to many apps and matches Let's Encrypt's recommended one-account-per-host integration pattern. Concurrent lego invocations are serialized with `flock` against a lockfile in the shared directory because lego itself does not lock its account store. `letsencrypt:revoke` falls back to the per-app account when the shared directory has no matching entry, so certificates issued before the upgrade can still be revoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lego accounts directory is now mounted from a shared host path so apps configured with the same
emailandserverreuse a single ACME account instead of each registering its own. This sidesteps the Let's Encrypt 10-new-accounts-per-IP-per-3-hours limit for hosts adding HTTPS to many apps and matches Let's Encrypt's recommended one-account-per-host integration pattern. Concurrent lego invocations are serialized withflockagainst a lockfile in the shared directory because lego itself does not lock its account store.letsencrypt:revokefalls back to the per-app account when the shared directory has no matching entry, so certificates issued before the upgrade can still be revoked.Closes #158