refactor: call fn-letsencrypt-enable from auto-renew#408
Merged
Conversation
Replaces the two `dokku letsencrypt:enable` sub-process invocations inside `cmd-letsencrypt-auto-renew` with direct calls to `fn-letsencrypt-enable`. The batch path runs in a sub-shell so a single app's `dokku_log_fail` no longer aborts the whole renewal sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the two
dokku letsencrypt:enablesub-process invocations insidecmd-letsencrypt-auto-renewwith direct calls tofn-letsencrypt-enable. The batch path runs in a sub-shell so a single app'sdokku_log_failno longer aborts the whole renewal sweep.The three remaining
dokku certs:add/dokku certs:removecall sites ininternal-functionscannot be converted today because the certs plugin in dokku core does not expose sourceable functions or plugin triggers for those operations; tracked upstream in dokku/dokku#8623. Thecron-jobscript andcron-entriestrigger keep invokingdokku letsencrypt:auto-renewbecause cron runs them in a fresh shell that needs the CLI wrapper to bootstrap the plugin env.