Add Kafka assignment diagnostics and prerelease package workflow#1
Draft
vaital3000 wants to merge 2 commits into
Draft
Add Kafka assignment diagnostics and prerelease package workflow#1vaital3000 wants to merge 2 commits into
vaital3000 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds targeted diagnostics around cooperative rebalance assignment handoff in Confluent.Kafka. The logs are emitted through the existing consumer log handler with the
ASSIGNDIAGfacility.Also adds a GitHub Actions workflow that publishes a prerelease
Confluent.Kafkapackage from branchkafka-assignment-diagnostics-v2.13.2to GitHub Packages.Diagnostic stages covered:
IncrementalAssignConsumer.IncrementalAssignmaterialized listSafeKafkaHandle.AssignImplmanaged input, native list count, and native call resultPackage Publishing
Workflow:
.github/workflows/publish-prerelease-package.ymlTriggers:
kafka-assignment-diagnostics-v2.13.2workflow_dispatchwith optionalversion_suffixThe workflow publishes a
net8.0prerelease package tohttps://nuget.pkg.github.com/dodopizza/index.jsonusingGITHUB_TOKENwithpackages: write.Latest published package from this branch:
Confluent.Kafkaversion2.13.2-dodo.kafka-assignment-diagnostics-v2-13-2.1.73238cf4Why
We need to distinguish whether a non-empty cooperative assignment is lost in the managed callback path, the managed-to-native list construction, or after entering librdkafka.
Validation
dotnet build src/Confluent.Kafka/Confluent.Kafka.csproj -f net8.0dotnet build src/Confluent.Kafka/Confluent.Kafka.csproj -f net6.0dotnet build src/Confluent.Kafka/Confluent.Kafka.csproj -f netstandard2.0dotnet test test/Confluent.Kafka.UnitTests/Confluent.Kafka.UnitTests.csproj -f net8.0dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c Release /p:TargetFrameworks=net8.0 /p:VersionSuffix=dodo.kafka-assignment-diagnostics-v2-13-2.0.localtest --output /tmp/confluent-kafka-package-testPublish prerelease package: passed and pushed the packageNote: full solution build was not run successfully on this macOS environment because it requires missing .NET Framework 4.6.2 targeting packs and restore assets for every example/test project.