Docs: replace XML config examples with array-based PHP - #2274
Open
llupa wants to merge 1 commit into
Open
Conversation
Author
|
Fixes #2273 A second more thorough read needs to be done before merging it directly 😅. I can say that I based the "style" off of YAML, because it felt natural to switch between YAML and PHP and have the same comments. |
GromNaN
approved these changes
Aug 12, 2026
Comment on lines
+352
to
+353
| return static function (ContainerConfigurator $containerConfigurator): void { | ||
| $containerConfigurator->extension('doctrine', [ |
Member
There was a problem hiding this comment.
This was the syntax before Symfony 7.4. It's now possible to just return a PHP array, eventually wrapped by App::config([...]) (see announcement blogpost).
I'm fine with keeping this version for now as it's supported by all supported Symfony versions from 6.4 to 8.
SenseException
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2273