Skip to content

Patch 2 Added a Russian translation patch-2 - #247

Merged
dmzz-yyhyy merged 10 commits into
dmzz-yyhyy:refactoringfrom
Xapitonov:patch-2
Jul 31, 2025
Merged

Patch 2 Added a Russian translation patch-2#247
dmzz-yyhyy merged 10 commits into
dmzz-yyhyy:refactoringfrom
Xapitonov:patch-2

Conversation

@Xapitonov

Copy link
Copy Markdown
Contributor

Added a Russian translation patch-2

Added a Russian translation.
Added a Russian translation.
Added a Russian translation.
Added a Russian translation.
Added a Russian translation.
Correction:
 [Русский](README_RU.md)
Added a Russian translation.
Added a Russian translation.
@Xapitonov

Copy link
Copy Markdown
Contributor Author

Hi. 🤝
I'm not sure if I did it right ? 🤔

@dmzz-yyhyy

Copy link
Copy Markdown
Owner

yes. we will deal with the rest

@Xapitonov

Copy link
Copy Markdown
Contributor Author

Ок, 😊

@yukonisen

Copy link
Copy Markdown
Collaborator

Hello, thanks for the great work!
This PR is ready to be merged after some minor fixes

@dmzz-yyhyy
dmzz-yyhyy merged commit b453a76 into dmzz-yyhyy:refactoring Jul 31, 2025
2 checks passed
@dmzz-yyhyy

dmzz-yyhyy commented Jul 31, 2025

Copy link
Copy Markdown
Owner

you can download the latest build file at https://github.com/dmzz-yyhyy/LightNovelReader/actions/runs/16646344739

@dmzz-yyhyy dmzz-yyhyy linked an issue Jul 31, 2025 that may be closed by this pull request
@dmzz-yyhyy

Copy link
Copy Markdown
Owner

um, I just noticed that you translated the epub module usage guide. Um, it feels amazing that you can translate the content of my sample code correctly...

@Xapitonov

Xapitonov commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

Hi! 🤝

I noticed that this string in strings.xml

<string name="navigate_to_explore"></string>

seems to be unused now. May I delete it to keep the resources clean? 🤔

I’d appreciate your confirmation! 🙏 😇

@dmzz-yyhyy

Copy link
Copy Markdown
Owner

wait for me to check it

@dmzz-yyhyy

Copy link
Copy Markdown
Owner

i feel that discussing under this PR is a bit cumbersome. would you like to add discord? considering that you are Russian, i also have telegram

@dmzz-yyhyy

Copy link
Copy Markdown
Owner
navigate_to_explore

i didn't see this in the latest commit
did you update your fork?

@Xapitonov

Xapitonov commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

I want to clarify that I worked not with the main localization file, but with this one:

LightNovelReader/app/src/main/res/values-ru-rRU/strings.xml

So, specifically with the file values-ru-rRU/strings.xml.

 <string name="navigate_to_explore">Перейти в раздел «Обзор»</string>

Could you please share the link to your Telegram for easier communication? Thank you!

@dmzz-yyhyy

Copy link
Copy Markdown
Owner

i make a telegram group https://t.me/+5R1ZZ7MAtXJmZjFl
i will check the file later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added a Russian translation patch-2 .

3 participants