Refuse to load npm package.json files - #3136
Open
AMDphreak wants to merge 2 commits into
Open
Conversation
When Dub finds a package.json with npm-only top-level keys (packageManager, scripts, devDependencies, workspaces, private), raise a hard error instead of parsing it as a Dub recipe. Fixes dlang#3118 Co-authored-by: Cursor <cursoragent@cursor.com>
Force-track package.json under test/ (gitignore only allowlists dub.json) and allowlist package.json test fixtures going forward. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your Pull Request and making D better! This comment will automatically be updated to summarize some statistics in a few minutes. |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonwhen it contains npm-only top-level keys (packageManager,scripts,devDependencies,workspaces,private), matching the proposal in Refuse to load npm package.json files #3118.package.jsonfilename (no npm sentinel keys)..fail_buildcase, and a changelog entry.Test plan
source/dub/recipe/io.d(npm refuse + legacy allow)test/issue3118-npm-package-jsonfails to build as expectedtest/1-exec-simple-package-jsonstill buildspackage.json,dub buildprints a clear refusal instead of unknown-key warningsFixes #3118