Skip to content

Option to swap out requestMIDIAccess function when enabling WebMIDI #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djipco merged 1 commit into from
Mar 26, 2022
Merged

Option to swap out requestMIDIAccess function when enabling WebMIDI #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/WebMidi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ class WebMidi extends EventEmitter {
* @param [options.software=false] {boolean} Whether to request access to software synthesizers on
* the host system. This is part of the spec but has not yet been implemented by most browsers as
* of April 2020.
*
* @param [options.requestMIDIAccessFunction] {function} A custom function to use to return
* the MIDIAccess object. This is useful if you want to use a polyfill for the Web MIDI API
* or if you want to use a custom implementation of the Web MIDI API - probably for testing
* purposes.
*
* @async
*
Expand Down Expand Up @@ -360,9 +365,15 @@ class WebMidi extends EventEmitter {

// Request MIDI access (this iw where the prompt will appear)
try {
this.interface = await navigator.requestMIDIAccess(
{sysex: options.sysex, software: options.software}
);
if (typeof options.requestMIDIAccessFunction === "function") {
this.interface = await options.requestMIDIAccessFunction(
{sysex: options.sysex, software: options.software}
);
} else {
this.interface = await navigator.requestMIDIAccess(
{sysex: options.sysex, software: options.software}
);
}
} catch(err) {
errorEvent.error = err;
this.emit("error", errorEvent);
Expand Down
1 change: 1 addition & 0 deletions typescript/webmidi.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5570,6 +5570,7 @@ declare class WebMidi extends EventEmitter {
sysex?: boolean;
validation?: boolean;
software?: boolean;
requestMIDIAccessFunction?: Function;
}): Promise<WebMidi>;

/**
Expand Down