Add a trim_whitespace convenience method#17
Merged
Conversation
Owner
|
Nice! |
Owner
|
Do you have more in store? If not I'll cut a new release soon. But if you do, I'd rather wait and collect them all. |
Contributor
Author
I think this is the last one in a while :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have implemented a convenience method that will help trim whitespaces when the user may need them.
There are cases when the response comes with some \r\n, which are not really necessary. Using this method, those bytes will be skipped, and the user only needs to think about the message.
Let's assume a message:
\r\nAT+CPIN: READY\r\n\r\nOK\r\n, if I want to parse this when I use the library, I need to take care of putting those \r\n. Using the trim_whitespace methods, the strings will be simplified, and the headaches of checking the whitespaces will be gone.Now the library performs the
trim_space, maybe that can be replaced with the 'trim_whitespaces'.