feat: add ability to parse raw string parameters#14
Conversation
|
Ah thanks! Really had to look exactly what you were doing here and how it's different from the existing non-parameter raw string parsing. It's been a while since I looked at this project. Lemme review it |
diondokter
left a comment
There was a problem hiding this comment.
Looks good! One little thing I'm curious what your thoughts are on.
Also, could you fix the clippy feedback? Seems like that's new and now is a nice opportunity to fix it.
Also, please add to the changelog under the unreleased section.
(i literally just ran cargo clippy --fix)
Haha don't worry about it, you did review it so fast that's impressive hehe. I thought this was initially a bug, mistaking a raw_string would be a parameter and stuff. The test I added makes the need a bit clearer :)
Done
I just ran a |
|
Released as 0.5.6 :) |
In this library, there a way to parse a raw string, but not as a parameter.
In AT commands responses, it's possible to get a integer value as an hexadecimal string, and then not quoted.
This Pull Request adds the ability to expect raw string parameters.