Skip to content

feat: add ability to parse raw string parameters#14

Merged
diondokter merged 4 commits into
diondokter:masterfrom
bachrc:master
Aug 20, 2025
Merged

feat: add ability to parse raw string parameters#14
diondokter merged 4 commits into
diondokter:masterfrom
bachrc:master

Conversation

@bachrc

@bachrc bachrc commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

In this library, there a way to parse a raw string, but not as a parameter.

In AT commands responses, it's possible to get a integer value as an hexadecimal string, and then not quoted.

This Pull Request adds the ability to expect raw string parameters.

@diondokter

Copy link
Copy Markdown
Owner

Ah thanks! Really had to look exactly what you were doing here and how it's different from the existing non-parameter raw string parsing. It's been a while since I looked at this project. Lemme review it

@diondokter diondokter left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One little thing I'm curious what your thoughts are on.

Also, could you fix the clippy feedback? Seems like that's new and now is a nice opportunity to fix it.

Also, please add to the changelog under the unreleased section.

Comment thread src/parser.rs Outdated
@bachrc

bachrc commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Ah thanks! Really had to look exactly what you were doing here and how it's different from the existing non-parameter raw string parsing. It's been a while since I looked at this project. Lemme review it

Haha don't worry about it, you did review it so fast that's impressive hehe. I thought this was initially a bug, mistaking a raw_string would be a parameter and stuff. The test I added makes the need a bit clearer :)

Also, please add to the changelog under the unreleased section.

Done

Also, could you fix the clippy feedback? Seems like that's new and now is a nice opportunity to fix it.

I just ran a cargo clippy --fix and it seems it's all green now :)

@bachrc bachrc requested a review from diondokter August 20, 2025 14:07

@diondokter diondokter left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@diondokter diondokter merged commit e576078 into diondokter:master Aug 20, 2025
4 checks passed
@diondokter

Copy link
Copy Markdown
Owner

Released as 0.5.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants