test(frontend): cover trading order filtering#13380
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent Trading tab search work added pure matcher coverage, but the
TradingOrderscomponent still lacked coverage for wiring those matchers into the rendered Active/History lists and the active order-book polling set. A regression there could show hidden orders, hide valid matches, or keep polling order books for rows filtered out of the UI.Changes
src/frontend/src/tests/lib/components/trading/TradingOrders.svelte.spec.ts.Tests
npm run format:file --file=src/frontend/src/tests/lib/components/trading/TradingOrders.svelte.spec.tsnpm run lint -- --max-warnings 0npm run check:testsnpm run checknpm run test -- --run src/frontend/src/tests/lib/components/trading/TradingOrders.svelte.spec.ts src/frontend/src/tests/lib/components/trading/TradingOrderRow.svelte.spec.ts src/frontend/src/tests/lib/components/trading/TradingAssets.svelte.spec.ts(3 files, 16 tests)Risky behavior now covered: Trading order search must filter visible Active/History rows consistently and must not poll order books for hidden active orders. These tests materially reduce regression risk because they exercise the component-level store/filter/polling integration that pure matcher tests cannot catch.