test(frontend): cover oisy trade canister wrappers#13341
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent OISY Trade wrapper changes added retry-aware
Resulthandling across several read and certified write methods, but onlygetMyOrdershad direct canister-wrapper coverage. These wrappers are core trading plumbing: a regression could silently drop arguments, return the wrongOkpayload, or lose retryability/reason metadata that callers use for recovery and UX.Risky behavior now covered:
Okunwrapping for balances, deposits, withdrawals, order-book reads, and limit-order mutations.Errmapping for temporary and request failures, including fallback reason discriminants.Changes
src/frontend/src/tests/lib/canisters/oisy-trade.canister.spec.tswith typed fixtures for trading pairs, balances, orders, requests, and responses.getBalances,deposit,withdraw,getOrderBookTicker,getOrderBookDepth,addLimitOrder, andcancelLimitOrder.getMyOrdersfixture with a concrete typedUserOrderfixture.Why these tests materially reduce regression risk:
Tests
PATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" npx vitest run src/frontend/src/tests/lib/canisters/oisy-trade.canister.spec.ts(17 tests)PATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" npx prettier --check src/frontend/src/tests/lib/canisters/oisy-trade.canister.spec.tsPATH="$HOME/.nvm/versions/node/v24.18.0/bin:$PATH" npx eslint src/frontend/src/tests/lib/canisters/oisy-trade.canister.spec.tsnpm run test -- src/frontend/src/tests/lib/canisters/oisy-trade.canister.spec.tsandnpm run check:testsfail before running this spec becausesrc/frontend/src/sol/utils/sol-instructions-system.utils.ts:96passesSystemInstruction.CreateAccountAllowPrefundtoassertNever.npm run lint -- --max-warnings 0reports Prettier issues in 33 unrelated files; the updated spec passes targeted Prettier and ESLint.