test(frontend): cover max balance button behavior#13302
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent MaxBalanceButton changes added fee-aware max calculations and a
maxAmountcap used by Liquidium repayment/supply flows. The existing spec only checked rendered labels, leaving the user-funds path where clicking Max mutatesamountand re-applies after fee changes untested.Risky behavior now covered:
maxAmountcap.maxAmountcaps still win after fee reservation.amountSetToMax.Changes
MaxBalanceButtonTestHost.svelteto expose bindableamountandamountSetToMaxstate in component tests.MaxBalanceButton.spec.tswith focused fee/cap/click/debounce regression cases.These tests materially reduce regression risk because
MaxBalanceButtonis shared across send/stake/Liquidium flows and directly controls the maximum spendable amount shown and submitted by users.Tests
npx @sveltejs/mcp svelte-autofixer ./src/frontend/src/tests/lib/components/common/MaxBalanceButtonTestHost.svelte --svelte-version 5npx prettier --check src/frontend/src/tests/lib/components/common/MaxBalanceButton.spec.ts src/frontend/src/tests/lib/components/common/MaxBalanceButtonTestHost.sveltenpx eslint src/frontend/src/tests/lib/components/common/MaxBalanceButton.spec.ts src/frontend/src/tests/lib/components/common/MaxBalanceButtonTestHost.svelte --max-warnings 0npx vitest run src/frontend/src/tests/lib/components/common/MaxBalanceButton.spec.tsNotes:
npm run test -- src/frontend/src/tests/lib/components/common/MaxBalanceButton.spec.tsis currently blocked before Vitest by an existing unrelated TypeScript error insrc/frontend/src/sol/utils/sol-instructions-system.utils.ts(SystemInstruction.CreateAccountAllowPrefundnot assignable tonever).npm run check:testsis blocked by the same existing unrelated TypeScript error.npm ciis blocked on this checkout by an existing package-lock sync issue (@emnapi/core/@emnapi/runtimemissing from lockfile), so dependencies were installed withnpm install --package-lock=falseto keep this PR test-only.