chore: migrate motoko/icrc2-swap to icp-cli#1386
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replace dfx.json with icp.yaml, migrate Motoko sources from src/swap/ to backend/, add icp-dev-env-motoko:0.3.2 CI workflow, update mops.toml to moc 1.9.0 / core 2.5.0 with --default-persistent-actors. Remove JS/Jest test suite, old deploy.sh, and prettier config; add Makefile with deploy and test targets that handle the multi-step deployment (token_a, token_b ICRC-1 ledger canisters via pre-built WASM, then backend swap canister with dynamic init args containing the token canister IDs). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/motoko@v5.0.0recipe for the swap backend andpre-builtbuild steps for the two ICRC-1/ICRC-2 token ledger canisters (token_a,token_b) from theledger-suite-icrc-2026-03-09releasesrc/swap/tobackend/(renamedmain.mo→app.mo)mops.tomltomoc = "1.9.0",core = "2.5.0", adds--default-persistent-actorsflagMakefilewithdeploytarget (multi-step: token ledgers first, then swap backend with dynamic init args using token canister IDs) andtesttarget with 5 canister call testsicrc2-swap.ymlCI workflow usingicp-dev-env-motoko:0.3.2, replacing the old dfx-based workflowtest/deploy.sh, prettier config, and all dfx artifactsREADME.mdto use icp-cli deploy instructionsNotes
The deployment requires a custom
make deploystep (rather than plainicp deploy) because the swap backend is an actor class whose init args (token_aandtoken_bcanister principals) are only known after deploying the token ledger canisters. The CI workflow callsmake deploy && make test.Test plan
icp network start -d && make deploy && make testpasses locallymops checkpasses with no errors🤖 Generated with Claude Code