chore: migrate motoko/classes to icp-cli#1385
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replaces dfx.json with icp.yaml, moves src/map/ → backend/ (Map.mo → app.mo, Buckets.mo), updates mops.toml to moc 1.9.0 / core 2.5.0 with --default-persistent-actors, adds Makefile with test/topup targets, adds CI workflow with --cycles 30t (example creates child Bucket canisters), updates README to icp-cli instructions, and removes BUILD.md, dfx.json, and .devcontainer/. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing the@dfinity/motoko@v5.0.0recipesrc/map/Map.mo→backend/app.mo,src/map/Buckets.mo→backend/Buckets.mosrc/test/Test.mo(test canister); testing moved toMakefileviaicp canister callmops.tomltomoc = "1.9.0",core = "2.5.0", adds--default-persistent-actorsflagpersistentkeyword from mainactor Map(covered by--default-persistent-actors); keepspersistentonactor class Bucket(actor class sub-WASMs require explicit keyword)Makefilewithtestandtopuptargets;icp deploy --cycles 30tused because the example dynamically creates childBucketcanisters.github/workflows/classes.ymlwithicp-dev-env-motoko:0.3.2container and--cycles 30tdeployBUILD.md,dfx.json, and.devcontainer/Test plan
icp network start -d && icp deploy --cycles 30tdeploys thebackendcanistermake testpasses all 4 tests (put/get, null for missing key, bucket distribution)make topupworks if cycles run outclasses.yml) runs on push/PR🤖 Generated with Claude Code