Skip cancelled Google Calendar events before sync matching#523
Closed
Zhepyrx wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this because I found #520 after opening, and it addresses the same IssueHunt-funded issue first. My PR added a slightly more defensive filter/log, but keeping a duplicate open would add maintainer noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
Summary
status: "cancelled"before building thecalendarEventsIdsmatching array.Why
The sync fetches existing Google Calendar events with
showDeleted: false, but issue discussion reports that cancelled events can still appear in this result set. If a cancelled event has the same extended private ID as an incoming ICS event, the sync attemptsCalendar.Events.update(...)against the cancelled event and can fail withInvalid start time.Filtering cancelled existing events before the ID/MD5 arrays are built prevents them from becoming update candidates.
Verification
All commands passed locally.