Skip to content

#455 Skip Sync When Feed Is Empty, and update email#456

Open
chadn wants to merge 1 commit into
derekantrican:masterfrom
chadn:skip-sync-when-feed-is-empty
Open

#455 Skip Sync When Feed Is Empty, and update email#456
chadn wants to merge 1 commit into
derekantrican:masterfrom
chadn:skip-sync-when-feed-is-empty

Conversation

@chadn

@chadn chadn commented Sep 11, 2024

Copy link
Copy Markdown

#455 if skipIfEmptyFeed == true, Skip Sync When Feed Is Empty, and change email to include if there were errors.

@LaurensdeGraaff LaurensdeGraaff left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Works good (tested))

@iditude

iditude commented May 16, 2025

Copy link
Copy Markdown

@chadn Sorry but I think you have a problem when it fails. The variable reportOverallFailure is never moved to true if the feed is empty so you don't see the error happening. I changed to the below and it works.

//------------------------ Fetch URL items ------------------------ var responses = fetchSourceCalendars(sourceCalendarURLs); if (responses.length == 0 && skipIfEmptyFeed){ Logger.log("Skipping this sync iteration due to empty feed (assuming temp problem), not modifying " + targetCalendarName); reportOverallFailure = true; continue; } Logger.log("Syncing " + responses.length + " calendars to " + targetCalendarName);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants