Add redirect support (limit: 6)#29
Open
martinheidegger wants to merge 4 commits into
Open
Conversation
Resolves issue #25.
pfrazee
requested changes
Mar 29, 2021
pfrazee
left a comment
pfrazee
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Added some minor feedback
| // dont use .well-known/dat | ||
| datDns.resolveName('foo.com', {noWellknownDat: true}) | ||
|
|
||
| // specify amount of redirects (default: 7) |
Contributor
There was a problem hiding this comment.
Is it 7 or 6? (Just looking at the constant in index.js)
| var ignoreCachedMiss = opts && opts.ignoreCachedMiss | ||
| var noDnsOverHttps = opts && opts.noDnsOverHttps | ||
| var noWellknownDat = opts && opts.noWellknownDat | ||
| var followRedirects = (opts && opts.followRedirects) || DEFAULT_FOLLOW_REDIRECTS |
Contributor
There was a problem hiding this comment.
Could we modify this so that 0 is allowed?
Contributor
Author
There was a problem hiding this comment.
added support & test in 7a488de - thanks for noticing.
| if ([301, 302, 307, 308].includes(res.statusCode)) { | ||
| if (!'location' in res.headers) { | ||
| debug('.well-known/' + recordName + ' lookup redirect did not contain destination Location header.') | ||
| throw new Error('Well record redirected to nowhere') |
Contributor
There was a problem hiding this comment.
Minor typo in this error description
Contributor
Author
There was a problem hiding this comment.
I adjust both this and the next error message in 7edfc1b
| // resolve relative paths with original URL as base URL | ||
| const uri = new URL(res.headers['location'], 'https://' + host) | ||
| if (uri.protocol !== 'https:') { | ||
| throw new Error('DNS record redirected to non https: protocol: ' + uri.href) |
Contributor
There was a problem hiding this comment.
Was it the DNS record or the HTTP response?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved implementation of #27. I used the findings of #27 and restructured the changes a bit, fixing a few things:
.well-knownfor the first request (but not redirects)Closes #25