On MacOS, main menu items display the title of their sub-menu rather than their own title - #15
On MacOS, main menu items display the title of their sub-menu rather than their own title#15TheBrokenRail wants to merge 1 commit into
Conversation
…than their own title (Fixes darlinghq/darling#679)
| } | ||
| } | ||
| } | ||
| return _title; |
There was a problem hiding this comment.
Is that how it works on macOS?
That is, does it return the original title if the submenu title is nil?
There was a problem hiding this comment.
I don't have a Mac to test with, but it seems to be reasonable fallback behavior if it is nil. Is there any situation where someone would set the menu title and not the submenu title and expect it to show up blank?
There was a problem hiding this comment.
I don't know; but this is Apple we're talking about, they're not known for always doing the sanest thing :)
This shouldn't be hard to check...
There was a problem hiding this comment.
To check all you should have to do is modify the example program from #679 so that the parent menus items have titles, not the submenus.
2 participants
Fixes darlinghq/darling#679