Fix heap allocation for light_tasking_rp2040 runtime#23
Merged
Conversation
This is intended to detect a regression on the RP2040 where doing heap allocation causes a linker error with the light_tasking_rp2040 runtime.
This is needed by s-memory.adb for the light_tasking_rp2040 runtime which does an atomic update of the pointer to the top of the heap.
The version provided by bb-runtimes does not implement __atomic_compare_exchange_4, which is required by System.Memory on light-tasking runtimes. This custom version adds that primitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
__atomic_compare_exchange_4for the RP2040 by disabling interrupts and using one of the RP2040 spinlocks (when in a multicore configuration). This is needed bys-memory.adbto atomically update the pointer to the top of the heap.Also added a regression test which reproduces the problem.
Fixes #22