Grfsv/task3 PullToRefreshの動作を追加 - #22
Merged
Merged
Conversation
mkeeda
reviewed
Aug 20, 2025
mkeeda
left a comment
Collaborator
There was a problem hiding this comment.
基本はバッチリだと思います!
細かい部分をコメントしました
added 2 commits
August 20, 2025 14:34
threadIdの値は現在利用していないが今後のテスト追加を考慮し、Mock関数の引数として残しておいた
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull to refreshでページの更新をする機能を追加しました。
更新中はpull to refreshのインジケータが表示される。
画面には前回の取得時に取得していた情報を表示し続ける。
UiStateに更新中を示すRefreshingを追加
初回ロード時と同じステータス(Loding)を利用した場合、画面中央のインジケータが表示されてしまう。更新時のインジケータと重複して表示されるため