chore: adds CRS to http-server example#1632
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR integrates the embedded OWASP CRS (coraza-coreruleset) into the http-server example by configuring a merged RootFS (embedded CRS + OS filesystem), updates default.conf with audit logging and default actions, renumbers custom rules, revises README docs and tests, and bumps dependencies in multiple go.mod files. ChangesCRS-enabled HTTP server example
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 87.66% 86.09% -1.57%
==========================================
Files 178 177 -1
Lines 9134 9128 -6
==========================================
- Hits 8007 7859 -148
- Misses 858 996 +138
- Partials 269 273 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Great. This PR surfaced a potential race condition when using multiphase evaluation. It will need some care. Moving to draft for now. |
It simplifies doing quick tests locally with the whole CRS.
Summary by CodeRabbit
New Features
Bug Fixes
Tests