feat(experimental): adds seclang parser

[jcchavezs]

what

• expose the seclang parser

why

• allow testing external parsers

[fzipi]

@jcchavezs Ready to merge?

[jcchavezs]

not really @fzipi I am hoping the requester to do something with it and validate this is needed before merge it.

…

On Sun, Jul 28, 2024 at 4:47 PM Felipe Zipitría ***@***.***> wrote: @jcchavezs <https://github.com/jcchavezs> Ready to merge? — Reply to this email directly, view it on GitHub <#1101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYASXT6LDIZ4P3ACUJBLZOUAARAVCNFSM6AAAAABLDMZYZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGU2DIMZWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[s3rj1k]

@jcchavezs Sorry I've been derailed a bit with other tasks, but this one is on my list, thanks

[s3rj1k]

Some really simple code to test:

package main

import (
	seclang "github.com/corazawaf/coraza/v3/experimental/seclang"
	"github.com/davecgh/go-spew/spew"
)

func main() {
	p := seclang.NewParser(seclang.NewParserConfig())
	err := p.FromFile("main.conf")
	spew.Dump(err)
}

go.mod:

module demo

go 1.22

require (
        github.com/corazawaf/coraza/v3 v3.2.2-0.20240728144702-a7a4be272baf
        github.com/davecgh/go-spew v1.1.1
)

Truncated output:

failed to parse string: failed to parse string: failed to compile the directive "secaction": ___Actual_Error_Message___

I can import parser from experimental packages, problem here is that it does not give any additional information like line number inside rule file or rule ID at least and error message is wrapped.

The original request idea was to allow external code interface directly with parser and get a bit more information in case of invalid rules, to help actually find invalid rules (line number, id, ...), in current state it does not help much.

[jcchavezs]

Valid point @s3rj1k. Try it now

$ go run examples/parser/main.go 
2024/10/07 10:42:42 [DEBUG] Parsing directive line="SecUnknown LoL"
2024/10/07 10:42:42 [ERROR] unknown directive "secunknown" line=4
(seclang.ParsingError) syntax error, unknown directive "secunknown" on rules/incorrect.conf:4

[s3rj1k]

@jcchavezs Yep, now it looks great and on-par with libmodsecurity, thanks!

[fzipi]

@jcchavezs Do we merge this one?

[jcchavezs]

@s3rj1k any chance you have public the code where you consume this parser? I am inclined to merge this but I would expect to have implementation code using this.

[s3rj1k]

any chance you have public the code where you consume this parser

sadly zero-chance